1482007 - Create a helper class to guarantee that nsIEditor::EndTransaction() is called after nsIEditor::BeginTransaction() call

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b91264cd5b9ef1d9d54cf1f8fdf454d503fa0eb

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1482007 - part 1: Create a helper class to guarantee to call nsIEditor::EndTransaction() after nsIEditor::BeginTransaction() call

This patch also creates non-virtual methods,
EditorBase::BeginTransactionInternal(), EditorBase::EndTransactionInternal(),
TransactionManager::BeginBatchInternal() and
TransactionManager::EndBatchInternal().

Although, this could be replaced with API to use PlaceholderTransaction,
we should investigate it when we have much time.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1482007 - part 2: Make all callers of EditorBase::BeginTransaction() use AutoTransactionBatch

This patch also removes LOCK_DOC() and UNLOCK_DOC() from TextServiceDocument.cpp
since they looks like we cannot use early-return style without call of
UNLOCK_DOC() even after removing EndTransaction() calls.  However, they
are defined as empty.  So, they do nothing even since first landing.
Therefore, there is no reason to keep them.

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 8998751 [details]
Bug 1482007 - part 1: Create a helper class to guarantee to call nsIEditor::EndTransaction() after nsIEditor::BeginTransaction() call

Makoto Kato [:m_kato] has approved the revision.

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 8998753 [details]
Bug 1482007 - part 2: Make all callers of EditorBase::BeginTransaction() use AutoTransactionBatch

Makoto Kato [:m_kato] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3392988c0894
part 1: Create a helper class to guarantee to call nsIEditor::EndTransaction() after nsIEditor::BeginTransaction() call r=m_kato

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/305478da57df
part 2: Make all callers of EditorBase::BeginTransaction() use AutoTransactionBatch r=m_kato

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3392988c0894
https://hg.mozilla.org/mozilla-central/rev/305478da57df