1482018 - Split HTMLEditor::Indent() for internal use

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1482018 - Create non-virtual methods of nsIHTMLEditor::Indent() equivalents

nsIHTMLEditor::Indent() is used for handling Tab key in HandleKeyPressEvent()
and used for implementing indent/outdent commands.  Unfortunately, it takes
string argument to switch between indent or outdent.  So, it does not make
sense to use this in C++ code.

This patch creates IndentAsAction() and OutdentAsAction() as public methods
and the implementation is moved to IndentOrOutdentAsSubAction() which takes
EditSubAction to switch between indent and outdent.

Note that HandleKeyPressEvent() uses the new public methods.  However, this
is not problem for the future changes since HandleKeyPressEvent() is an
exception which may call other public methods.

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 8999562 [details]
Bug 1482018 - Create non-virtual methods of nsIHTMLEditor::Indent() equivalents

Makoto Kato [:m_kato] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0819f9d226d
Create non-virtual methods of nsIHTMLEditor::Indent() equivalents r=m_kato

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f0819f9d226d