1482020 - Make HTMLEditor::InsertTableCell(() use non-virtual HTMLEditor::CreateElementWithDefaults() instead of nsIHTMLEditor::CreateElementWithDefaults()

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fc5d1381cb10dd2bc7654a3b3de29c855098465

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0f53f2cce2e1c1fbfa4400c32d7fa228766b73d

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8595a69bcbef7d135ecc89e0377dd64f74ecf97b

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1482020 - Make all callers of CreateElementWithDefaults() use non-virtual method

Fortunately, despite of becoming public method,
HTMLEditor::CreateElementWithDefaults() can be used by internal methods too
since it does not touch undo transactions nor the DOM tree, and does not
refer mRules nor GetSelection().  So, we can make it public and make any
C++ callers use it.

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 8999611 [details]
Bug 1482020 - Make all callers of CreateElementWithDefaults() use non-virtual method

Makoto Kato [:m_kato] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/417967cf69de
Make all callers of CreateElementWithDefaults() use non-virtual method r=m_kato

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/417967cf69de