1482022 - Split HTMLEditor::RemoveOverrideStyleSheet() for internal use

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1482022 - Create HTMLEditor::RemoveOverrideStyleSheetInternal() for internal use

HTMLEditor::RemoveOverrideStyleSheet() is an XPCOM method but used internally.
So, we should create non-virtual method for this.

Additionally, it calls GetStyleSheetForURL() and RemoveStyleSheetFromList(),
but they search index of internal override style sheet array redundantly.
Moreover, RemoveStyleSheetFromList() returns error only when given URL is
not found, but RemoveOverrideStyleSheet() which is the only one caller, ignores
the error.  Therefore, for saving the redundant cost, this patch makes
RemoveStyleSheetFromList() return removing StyleSheet which is retrieved
with the call of GetStyleSheetForURL().  So, RemoveOverrideStyleSheetInternal()
stops calling GetStyleSheetForURL().

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 9001455 [details]
Bug 1482022 - Create HTMLEditor::RemoveOverrideStyleSheetInternal() for internal use

Makoto Kato [:m_kato] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c023e0cd20f
Create HTMLEditor::RemoveOverrideStyleSheetInternal() for internal use r=m_kato

Comment 4

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/4c023e0cd20f