Closed Bug 1482052 Opened 4 years ago Closed 4 years ago

Add more sources to custom damp test for the debugger


(DevTools :: Debugger, enhancement, P3)



(firefox63 affected)

Firefox 63
Tracking Status
firefox63 --- affected


(Reporter: yulia, Assigned: yulia)




(1 file)

We recently introduced Lazy scripts to the debugger server, but we have not seen an impact on DAMP that we expected. This is likely due to the fact that none of our example tests have a sufficient number of files being loaded. We should add a large number of sources to the custom test and compare the results of this test to the revision before the lazy scripts landed in bug #1434305
We do not have a test case in talos that has many files to be loaded on start. This change adds 100
files, each around 1000 lines long.
Assignee: nobody → ystartsev
* Instead of having 100 distinct files (and increasing m-c repo size),
can we have only one and trick the engine by using query strings like this:
  <script type="text/javascript" src="./js/test.js?id=1"></script>
  <script type="text/javascript" src="./js/test.js?id=2"></script>
  <script type="text/javascript" src="./js/test.js?id=3"></script>

* Can you attach links to perfherder compare pages?

* index.html would be more readable with `\n` after each `</script>`

* main.js and have been renamed for some reason
console.autocomplete is 2 times slower with this patch.
Could you investigate that?

It is obvious that custom.jsdebugger will be slower.
I can also understand that tests running after debugger will be slightly slower due to GC increase.
But making a 1s test become a 2s one is suspicious.

It would be interesting to request a profile and see if there is any stack traces related to the debugger happening during autocomplete test.
I requested a profile on try run:
Once it is done, it should be available in:
  Linux x64 Nightly opt -- T-P-e10s(damp)

Also note that on this try run, you can see an intermittent failure:
  PID 2218 | TEST-UNEXPECTED-FAIL | damp | debugger/custom.js: TypeError: source is undefined
  Only failed once on OSX:
Comment on attachment 8999868 [details]
Bug 1482052 - add talos test with many files for the debugger; r=ochameau

Alexandre Poirot [:ochameau] has approved the revision.
Attachment #8999868 - Flags: review+
Pushed by
add talos test with many files for the debugger; r=ochameau
See Also: → 1484684
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Backout by
Backed out changeset 9c29ffcfc052 for damp test failures a=backout
Pushed by
add talos test with many files for the debugger; r=ochameau
You need to log in before you can comment on or make changes to this bug.