Closed Bug 1482054 Opened Last year Closed Last year

[remote-dbg-next] Add network locations in Connect page

Categories

(DevTools :: about:debugging, enhancement, P1)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(7 files)

The goal of this bug is to add the UI to list/add/remove network locations from the Connect page of the new about:debugging.
Comment on attachment 8999119 [details]
Bug 1482054 - Group aboutdebugging constants together;r=daisuke

Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #8999119 - Flags: review+
Comment on attachment 8999120 [details]
Bug 1482054 - Sort rules in ConnectPage.css alphabetically;r=daisuke

Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #8999120 - Flags: review+
In order to reuse the button and ellipsis styles in the Connect page,
I would like to move the corresponding styles to a common stylesheet.

Depends on D3094
This patch introduces a new preference:
  devtools.aboutdebugging.network-locations

- this preference is a string pref, that should be a stringified
  JavaScript array.
- the default value is "[]".
- the module supports getting, adding, removing and observing
  network locations.

Depends on D3095
This icon is copied from the common globe icon, except that it supports
context-fill.

Depends on D3096
Comment on attachment 8999122 [details]
Bug 1482054 - Fix classname for ConnectPage;r=daisuke

Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #8999122 - Flags: review+
Comment on attachment 8999123 [details]
Bug 1482054 - Move .button and .ellipsis-text to aboutdebugging.css;r=daisuke

Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #8999123 - Flags: review+
Comment on attachment 8999127 [details]
Bug 1482054 - Add icon for network section of connect page;r=daisuke

Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #8999127 - Flags: review+
Comment on attachment 8999128 [details]
Bug 1482054 - List existing network locations in Connect Page;r=daisuke

Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #8999128 - Flags: review+
Comment on attachment 8999125 [details]
Bug 1482054 - Create module to manage network locations;r=daisuke

Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #8999125 - Flags: review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b41545e3d60d
Group aboutdebugging constants together;r=daisuke
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5b9d0ee244d
Sort rules in ConnectPage.css alphabetically;r=daisuke
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec43c1941881
Move .button and .ellipsis-text to aboutdebugging.css;r=daisuke
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d6272c35ae8
Create module to manage network locations;r=daisuke
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50bbb02dc5c9
Add icon for network section of connect page;r=daisuke
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a3d6bc157c8
List existing network locations in Connect Page;r=daisuke
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8413a2a9c0c1
Allow to add and remove network locations in Connect Page;r=daisuke
Priority: -- → P1
You need to log in before you can comment on or make changes to this bug.