1482054 - [remote-dbg-next] Add network locations in Connect page

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

The goal of this bug is to add the UI to list/add/remove network locations from the Connect page of the new about:debugging.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1482054 - Group aboutdebugging constants together;r=daisuke

Comment 2

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8999119 [details]
Bug 1482054 - Group aboutdebugging constants together;r=daisuke

Daisuke Akatsuka (:daisuke) has approved the revision.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1482054 - Sort rules in ConnectPage.css alphabetically;r=daisuke

Depends on D3092

Comment 4

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8999120 [details]
Bug 1482054 - Sort rules in ConnectPage.css alphabetically;r=daisuke

Daisuke Akatsuka (:daisuke) has approved the revision.

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1482054 - Fix classname for ConnectPage;r=daisuke

Depends on D3093

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1482054 - Move .button and .ellipsis-text to aboutdebugging.css;r=daisuke

In order to reuse the button and ellipsis styles in the Connect page,
I would like to move the corresponding styles to a common stylesheet.

Depends on D3094

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1482054 - Create module to manage network locations;r=daisuke

This patch introduces a new preference:
  devtools.aboutdebugging.network-locations

- this preference is a string pref, that should be a stringified
  JavaScript array.
- the default value is "[]".
- the module supports getting, adding, removing and observing
  network locations.

Depends on D3095

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1482054 - Add icon for network section of connect page;r=daisuke

This icon is copied from the common globe icon, except that it supports
context-fill.

Depends on D3096

Comment 9

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8999122 [details]
Bug 1482054 - Fix classname for ConnectPage;r=daisuke

Daisuke Akatsuka (:daisuke) has approved the revision.

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: Bug 1482054 - List existing network locations in Connect Page;r=daisuke

Depends on D3097

Comment 11

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8999123 [details]
Bug 1482054 - Move .button and .ellipsis-text to aboutdebugging.css;r=daisuke

Daisuke Akatsuka (:daisuke) has approved the revision.

Comment 12

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8999127 [details]
Bug 1482054 - Add icon for network section of connect page;r=daisuke

Daisuke Akatsuka (:daisuke) has approved the revision.

Comment 13

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8999128 [details]
Bug 1482054 - List existing network locations in Connect Page;r=daisuke

Daisuke Akatsuka (:daisuke) has approved the revision.

Comment 14

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8999125 [details]
Bug 1482054 - Create module to manage network locations;r=daisuke

Daisuke Akatsuka (:daisuke) has approved the revision.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b41545e3d60d
Group aboutdebugging constants together;r=daisuke

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5b9d0ee244d
Sort rules in ConnectPage.css alphabetically;r=daisuke

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cdf6161812fb
Fix classname for ConnectPage;r=daisuke

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec43c1941881
Move .button and .ellipsis-text to aboutdebugging.css;r=daisuke

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d6272c35ae8
Create module to manage network locations;r=daisuke

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50bbb02dc5c9
Add icon for network section of connect page;r=daisuke

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a3d6bc157c8
List existing network locations in Connect Page;r=daisuke

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8413a2a9c0c1
Allow to add and remove network locations in Connect Page;r=daisuke

Comment 23

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b41545e3d60d
https://hg.mozilla.org/mozilla-central/rev/c5b9d0ee244d
https://hg.mozilla.org/mozilla-central/rev/cdf6161812fb
https://hg.mozilla.org/mozilla-central/rev/ec43c1941881
https://hg.mozilla.org/mozilla-central/rev/2d6272c35ae8
https://hg.mozilla.org/mozilla-central/rev/50bbb02dc5c9
https://hg.mozilla.org/mozilla-central/rev/2a3d6bc157c8
https://hg.mozilla.org/mozilla-central/rev/8413a2a9c0c1