1482113 - Don't collect metrics when previewing Snippets

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Giorgos Logiotatidis [:giorgos]]

When previewing Snippets in AS Router we shouldn't collect any snippet related metrics (impression, click, etc).

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

To clarify, this is about previewing snippets using the about:newtab?endpoint=URL mechanism. *grabs*

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4431

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/0db5021394d946812f25e1c4754af9978bef9b71
Fix Bug 1482113 - Don't collect metrics when previewing Snippets (#4431)

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/95f8e6265f24

Comment 5

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I've changed the 

browser.newtabpage.activity-stream.asrouter.messageProviders

pref to

[{"id":"onboarding","type":"local","localProvider":"OnboardingMessageProvider","enabled":false,"cohort":0},{"id":"snippets","type":"remote","url":"https://snippets.cdn.mozilla.net/%STARTPAGE_VERSION%/%NAME%/%VERSION%/%APPBUILDID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/","updateCycleInMs":14400000,"enabled":true},{"id":"cfr","type":"local","localProvider":"CFRMessageProvider","enabled":true,"cohort":"nightly"}]

which enabled snippets while I am on about:newtab#asrouter, but any action I take on the snippet is still considered valid. Which leads me to believe that I'm looking in the wrong place.

@Ricky, is there any other way I can verify this issue?

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Sent the info on slack.

Testing doc:
https://docs.google.com/document/d/1rJXREddGUx0F7J3sseQbYXY_tkW4wL1CEyaxbRbn-pg/edit

in order to test this, you can follow the same steps in the document but instead whitelist `gist.githubusercontent.com` and use this endpoint https://gist.githubusercontent.com/piatra/70234f08696c0a0509d7ba5568cd830f/raw/41338334ba7e523020b0ea9a875f872ccb050633/messages.json

Comment 7

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Thanks again Ricky for your help with this.

I have verified that the issue is no longer reproducible on the latest Nightly 64.0a1 (Build ID 20180927100044) on Windows 10 x64, Mac 10.13.3, and Arch Linux x64.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

The status for 63 was set to affected by the AS team - is this something we intend to request approval on or is it riding the trains?

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

Oh I see. This isn't worth uplifting. Let it ride the choo choo