1482116 - Potential null deref when setting CDM

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

We have:
https://searchfox.org/mozilla-central/source/dom/media/MediaFormatReader.cpp#1477

which schedule an update regardless of a track being present or not.

This could cause null-deref depending where in the timeline we are.

This can be easily reproduced by setting in a debug build MediaFormatReader:5 logging and running the test dom/media/test/test_eme_autoplay.html

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1482116 - Only schedule update when a track exists. r?bryce

Add assertion to more easily catch the problem

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 8998856 [details]
Bug 1482116 - Only schedule update when a track exists. r?bryce

Bryce Seager van Dyk (:bryce) has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb68137ed8a9
Only schedule update when a track exists. r=bryce

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/bb68137ed8a9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

I'm assuming this can ride the trains, but feel free to request branch approvals if you feel like it should be uplifted.