Closed Bug 1482138 Opened 2 years ago Closed 2 years ago

Expose "Add search engine" string from search.properties for use in Search Shortcut editing menu

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 63
Iteration:
63.4 - Aug 20
Tracking Status
firefox62 --- wontfix
firefox63 --- fixed

People

(Reporter: k88hudson, Assigned: Mardak)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This string is needed as stop-gap for the search shortcuts editing menu in 62. For 63, we will localize it properly in newtab's strings.
Severity: normal → enhancement
Iteration: --- → 63.4 - Aug 20
Priority: -- → P2
We'll grab the search.properties string if it isn't already translated in newtab.properties as per 1480507 comment 4.

This doesn't directly block bug 1480507 as that bug can land the new string, and other locales will fall back to en-US until this lands.
Assignee: nobody → edilee
Priority: P2 → P1
See Also: → 1480507
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/512f9129d4916c9db0da32ac45e74de17871c3bd
fix(strings): Fall back to existing translation of search.properties "Add Search Engine" (#4311)

Fix Bug 1482138 - Expose "Add search engine" string from search.properties for use in Search Shortcut editing menu
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Blocks: 1482523
https://hg.mozilla.org/mozilla-central/rev/322c3cf43fe8
Target Milestone: --- → Firefox 63
Strings were copied from activity stream master strings import instead of running this updated script on the firefox-62 branch to avoid missing en-US strings.
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.