1482138 - Expose "Add search engine" string from search.properties for use in Search Shortcut editing menu

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Kate Hudson :k88hudson]

This string is needed as stop-gap for the search shortcuts editing menu in 62. For 63, we will localize it properly in newtab's strings.

Comment 1

[Ed Lee :Mardak]

We'll grab the search.properties string if it isn't already translated in newtab.properties as per 1480507 comment 4.

This doesn't directly block bug 1480507 as that bug can land the new string, and other locales will fall back to en-US until this lands.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4311

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/512f9129d4916c9db0da32ac45e74de17871c3bd
fix(strings): Fall back to existing translation of search.properties "Add Search Engine" (#4311)

Fix Bug 1482138 - Expose "Add search engine" string from search.properties for use in Search Shortcut editing menu

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/322c3cf43fe8

Comment 5

[Ed Lee :Mardak]

Strings were copied from activity stream master strings import instead of running this updated script on the firefox-62 branch to avoid missing en-US strings.