Closed Bug 1482198 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12383 - RTCIceTransport: gather() implementation.

Categories

(Core :: WebRTC, enhancement, P4)

Product:
Core
Component:
WebRTC
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 12383 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12383
Details from upstream follow.

Steve Anton <steveanton@chromium.org> wrote:
>  RTCIceTransport: gather() implementation.
>  
>  This change implements the RTCIceTransport.gather() method and
>  associated methods/events: getLocalCandidates(), gatheringState,
>  ongatheringstatechange, and onlocalcandidate.
>  
>  The state property is also partially implemented so that the
>  RTCIceTransport can be stopped and garbage collected.
>  
>  Bug: 864871
>  Change-Id: I7056764789d92dc93038a7a2279a15c850b4d299
>  Reviewed-on: https://chromium-review.googlesource.com/1153845
>  WPT-Export-Revision: f29f3c5fe1e428166df5d374b4e597e7470a7f0b
PR 12383 applied with additional changes from upstream: c4bd959ae80333a356e43c651ea26ee4baf017e2
Component: web-platform-tests → WebRTC
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests and 13 subtests
OK     : 1
FAIL   : 13

New tests that have failures or other problems:
/webrtc/RTCIceTransport-extension.https.html
    RTCIceTransport constructor does not throw.: FAIL
    RTCIceTransport initial properties are set.: FAIL
    eventually transition gatheringState to 'complete': FAIL
    gather() returns at least one host candidate: FAIL
    gather() returns no candidates with { gatherPolicy: 'relay'} and no turn servers: FAIL
    gather() throws if called twice: FAIL
    gather() throws if closed: FAIL
    gather() transitions gatheringState to 'gathering': FAIL
    gather() with 2 stun servers should succeed: FAIL
    gather() with one turns server, one turn server, username, credential should succeed: FAIL
    gather() with { iceServers: null } should throw TypeError: FAIL
    gather() with { iceServers: undefined } should succeed: FAIL
    onicecandidate fires with null candidate before gatheringState transitions to 'complete': FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37aaa5c533e9
[wpt PR 12383] - RTCIceTransport: gather() implementation., a=testonly
https://hg.mozilla.org/mozilla-central/rev/37aaa5c533e9
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.