1482198 - [wpt-sync] Sync PR 12383 - RTCIceTransport: gather() implementation.

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 12383 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12383
Details from upstream follow.

Steve Anton <[e-mail]> wrote:
>  RTCIceTransport: gather() implementation.
>  
>  This change implements the RTCIceTransport.gather() method and
>  associated methods/events: getLocalCandidates(), gatheringState,
>  ongatheringstatechange, and onlocalcandidate.
>  
>  The state property is also partially implemented so that the
>  RTCIceTransport can be stopped and garbage collected.
>  
>  Bug: 864871
>  Change-Id: I7056764789d92dc93038a7a2279a15c850b4d299
>  Reviewed-on: https://chromium-review.googlesource.com/1153845
>  WPT-Export-Revision: f29f3c5fe1e428166df5d374b4e597e7470a7f0b

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 12383 applied with additional changes from upstream: c4bd959ae80333a356e43c651ea26ee4baf017e2

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa219bc3f9a2c19eb479b332ed373aed5204b59a

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba0ae701820032d61d9f55785b268c720ca25193

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=7abce7a24bedc9f33c02a05f1e32e148b97b0ff5

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f1373e828736b7084c7d2df4b9e3deb56be5ce4

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 1 tests and 13 subtests
OK     : 1
FAIL   : 13

New tests that have failures or other problems:
/webrtc/RTCIceTransport-extension.https.html
    RTCIceTransport constructor does not throw.: FAIL
    RTCIceTransport initial properties are set.: FAIL
    eventually transition gatheringState to 'complete': FAIL
    gather() returns at least one host candidate: FAIL
    gather() returns no candidates with { gatherPolicy: 'relay'} and no turn servers: FAIL
    gather() throws if called twice: FAIL
    gather() throws if closed: FAIL
    gather() transitions gatheringState to 'gathering': FAIL
    gather() with 2 stun servers should succeed: FAIL
    gather() with one turns server, one turn server, username, credential should succeed: FAIL
    gather() with { iceServers: null } should throw TypeError: FAIL
    gather() with { iceServers: undefined } should succeed: FAIL
    onicecandidate fires with null candidate before gatheringState transitions to 'complete': FAIL

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37aaa5c533e9
[wpt PR 12383] - RTCIceTransport: gather() implementation., a=testonly

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/37aaa5c533e9