1482200 - Remove getBoolPref helper function

Status: RESOLVED FIXED

(Firefox :: Search, enhancement, P5)

Description

[Mike Kaply [:mkaply]]

Now that we have pref APIs that take defaults, we should be able to completely remove the getBoolPref helper function in search.

Comment 1

[Diego Pino]

Attachment: 0001-Remove-getBoolPref-helper-function.patch

I'm attaching a patch. I think it should fix the issue, but maybe I'm missing something.

Comment 2

[Mike Kaply [:mkaply]]

This looks great, but one change was made to the nsSearchService recently to remove one part of this patch.

Do you mind updating to the latest version of Firefox and reattaching the patch? It should only conflict in one place.

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 8999946 [details] [diff] [review]
0001-Remove-getBoolPref-helper-function.patch

Review of attachment 8999946 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, but like Mike said (and I'll take his word for it), could you please update the patch based on the latest code?  Thanks

Comment 4

[Diego Pino]

Attachment: 0001-Remove-getBoolPref-helper-function.patch

Patch updated.

Comment 5

[Diego Pino]

Attachment: Bug-1482200-Remove-getBoolPref-helper-function.patch

Comment 6

[Drew Willcoxon :adw]

Comment on attachment 9003061 [details] [diff] [review]
Bug-1482200-Remove-getBoolPref-helper-function.patch

Review of attachment 9003061 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 7

[Diego Pino]

Attachment: Bug-1482200-Remove-getBoolPref-helper-function.-r-ad.patch

Added reviewer to commit message.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/589011790e72
Remove getBoolPref helper function. r=adw

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/589011790e72