Remove getBoolPref helper function

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P5
normal
RESOLVED FIXED
11 months ago
10 months ago

People

(Reporter: mkaply, Assigned: dpino)

Tracking

({good-first-bug})

Trunk
Firefox 63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Reporter

Description

11 months ago
Now that we have pref APIs that take defaults, we should be able to completely remove the getBoolPref helper function in search.
Reporter

Updated

11 months ago
Priority: -- → P5
Assignee

Comment 1

11 months ago
I'm attaching a patch. I think it should fix the issue, but maybe I'm missing something.
Attachment #8999946 - Flags: review?(adw)
Reporter

Comment 2

10 months ago
This looks great, but one change was made to the nsSearchService recently to remove one part of this patch.

Do you mind updating to the latest version of Firefox and reattaching the patch? It should only conflict in one place.

Comment 3

10 months ago
Comment on attachment 8999946 [details] [diff] [review]
0001-Remove-getBoolPref-helper-function.patch

Review of attachment 8999946 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, but like Mike said (and I'll take his word for it), could you please update the patch based on the latest code?  Thanks
Attachment #8999946 - Flags: review?(adw)

Updated

10 months ago
Assignee: nobody → dpino
Status: NEW → ASSIGNED
Assignee

Comment 4

10 months ago
Patch updated.
Attachment #8999946 - Attachment is obsolete: true
Assignee

Comment 5

10 months ago
Attachment #9003030 - Attachment is obsolete: true
Attachment #9003061 - Flags: review?(adw)

Comment 6

10 months ago
Comment on attachment 9003061 [details] [diff] [review]
Bug-1482200-Remove-getBoolPref-helper-function.patch

Review of attachment 9003061 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!
Attachment #9003061 - Flags: review?(adw) → review+
Assignee

Comment 7

10 months ago
Added reviewer to commit message.
Attachment #9003061 - Attachment is obsolete: true
Assignee

Updated

10 months ago
Keywords: checkin-needed

Comment 8

10 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/589011790e72
Remove getBoolPref helper function. r=adw
Keywords: checkin-needed

Comment 9

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/589011790e72
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.