1482482 - Add reftests for CSS Style Containment

Status: NEW

(Core :: Layout, enhancement, P3)

Comment 1

[Yusuf Sermet [:yusuf]]

Attachment: Bug 1482482 - Add reftests for CSS Style Containment

Add reftest for style containment for quotes and counters

Comment 2

[Yusuf Sermet [:yusuf]]

I added some reftests for quotes and counters for style containment. This tests are in now way comprehensive enough to cover all edge cases, but I think they would do an OK job covering the basics of style containment and most of them are a must-have.

Since there is difference in our current implementation and what the spec says about handling the ::after, not all of the tests are submitted to w3c (as suggested by dholbert), but some are for our internal usage.

All tests for quotes include the ::after element, so, they are all for Firefox only.

All tests for counters *don't* have ::after element, so, they are submitted to w3c.

Comment 3

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Thanks, yusuf!

BTW: I suggested that yusuf split this bug off from bug 1463600 in the interests of getting some pieces landed sooner & to make the review/landing process a bit more incremental, potentially.

I'm guessing the tests (this bug's patch) may be easier to sanity-check and get landed on their own, before the code patch [though the tests would presumably need to land with some "fails" annotations at this point, and bug 1463600's patch would ultimately remove those fails annotations, for tests that it converts from failing to passing].

Comment 4

[Yusuf Sermet [:yusuf]]

(In reply to Daniel Holbert [:dholbert] from comment #3)
> Thanks, yusuf!

> [though the tests would presumably need to land with some "fails"
> annotations at this point, and bug 1463600's patch would ultimately
> remove those fails annotations, for tests that it converts from failing to passing].

Just added the fail expectations and fixed the no-newline-at-ending's.

Thank you!

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.