1482494 - Intermittent browser/base/content/test/urlbar/browser_urlbarSearchFunction.js | "" == "basic" - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/urlbar/browser_urlbarSearchFunction.js :: assertUrlbarValue :: line 210

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: btara [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=193284159&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/EVm1nH9iRrWMKsW5_YsQ6g/runs/0/artifacts/public/logs/live_backing.log

07:24:14     INFO - TEST-START | browser/base/content/test/urlbar/browser_urlbarSearchFunction.js
07:24:15     INFO - TEST-INFO | started process screencapture
07:24:15     INFO - TEST-INFO | screencapture: exit 0
07:24:15     INFO - Buffered messages logged at 07:24:14
07:24:15     INFO - Entering test bound init
07:24:15     INFO - Leaving test bound init
07:24:15     INFO - Entering test bound basic
07:24:15     INFO - Buffered messages logged at 07:24:15
07:24:15     INFO - Restore popup dontAnimate value to false
07:24:15     INFO - Buffered messages finished
07:24:15     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/urlbar/browser_urlbarSearchFunction.js | "" == "basic" - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/urlbar/browser_urlbarSearchFunction.js :: assertUrlbarValue :: line 210
07:24:15     INFO - Stack trace:
07:24:15     INFO - chrome://mochitests/content/browser/browser/base/content/test/urlbar/browser_urlbarSearchFunction.js:assertUrlbarValue:210
07:24:15     INFO - chrome://mochitests/content/browser/browser/base/content/test/urlbar/browser_urlbarSearchFunction.js:basic:34
07:24:15     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1106
07:24:15     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
07:24:15     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:999
07:24:15     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
07:24:15     INFO - TEST-PASS | browser/base/content/test/urlbar/browser_urlbarSearchFunction.js | true == true -

Comment 1

[Cosmin Sabou [:CosminS]]

This test was introduced with this changeset: https://hg.mozilla.org/integration/autoland/rev/9d267b4bd26889fe936dff2c7b05d3b9415ccb44 but did not start failing on that push http://tinyurl.com/ya5rl4zm

It was first classified over here http://tinyurl.com/y886mw8n and retriggering around that time https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=OS%20X%2010.10%20debug%20Mochitests%20with%20e10s%20test-macosx64%2Fdebug-mochitest-browser-chrome-e10s-3%20M-e10s(bc3)&fromchange=e57c44d5ec978b70bbfb0d44152b5625a5b8997a&tochange=c9cc4b80fefa156da51c83c6539453c1b84e71d9&selectedJob=193533285 showed up that it began failing with this push from Johann where it failed 6 times out of 20 - http://tinyurl.com/yavav5kx.

Johann, can you please take a look over this? Thank you.

Comment 2

[Intermittent Failures Robot]

15 failures in 2579 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 15

Platform breakdown:
* windows7-32: 1
* linux32: 1
* osx-10-10: 13

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1482494&startday=2018-08-06&endday=2018-08-12&tree=all

Comment 3

[Intermittent Failures Robot]

38 failures in 594 pushes (0.064 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 16
* autoland: 14
* mozilla-central: 7
* try: 1

Platform breakdown:
* windows7-32: 5
* macosx64-nightly: 1
* windows10-64: 4
* linux32: 4
* osx-10-10: 13
* linux64: 11

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1482494&startday=2018-08-14&endday=2018-08-14&tree=all

Comment 4

[Johann Hofmann [:johannh]]

Well my patch touches a bit of stuff in the identity block, which is of course in close proximity to the urlbar, but I can't imagine that the root cause for the intermittentness lies in my patch. Drew, do you have any idea what this is? I'm generally happy to support the effort here but I have no idea what this test does or why code touching the identity block should affect it.

Comment 5

[Intermittent Failures Robot]

86 failures in 494 pushes (0.174 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. ** 

Repository breakdown:
* try: 5
* mozilla-central: 9
* autoland: 24
* mozilla-inbound: 48

Platform breakdown:
* osx-10-10: 17
* linux64-devedition: 1
* windows7-32: 13
* linux32: 13
* windows10-64-msvc: 1
* windows10-64: 13
* linux64: 28

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1482494&startday=2018-08-15&endday=2018-08-15&tree=all

Comment 6

[Intermittent Failures Robot]

106 failures in 527 pushes (0.201 failures/push) were associated with this bug yesterday.

Repository breakdown:
* try: 11
* mozilla-central: 7
* autoland: 35
* mozilla-inbound: 53

Platform breakdown:
* windows7-32: 17
* macosx64-nightly: 2
* linux32: 15
* windows7-32-msvc: 1
* windows10-64: 17
* linux32-nightly: 2
* linux64-nightly: 1
* linux64-devedition: 1
* windows10-64-devedition: 1
* osx-10-10: 32
* linux64: 17

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1482494&startday=2018-08-16&endday=2018-08-16&tree=all

Comment 7

[Narcis Beleuzu [:NarcisB]]

Attachment: Disable test on all platforms

There are 358 failures in the last 7 days.
Attached a patch to disable the test until the issue will be fixed

Comment 8

[Intermittent Failures Robot]

49 failures in 115 pushes (0.426 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-central: 12
* autoland: 16
* mozilla-inbound: 19
* try: 2

Platform breakdown:
* linux32-nightly: 1
* macosx64-nightly: 2
* windows7-32-msvc: 1
* osx-10-10: 10
* linux64: 10
* windows7-32: 8
* linux32: 6
* windows10-64: 11

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1482494&startday=2018-08-18&endday=2018-08-18&tree=all

Comment 9

[Intermittent Failures Robot]

451 failures in 2672 pushes (0.169 failures/push) were associated with this bug in the last 7 days.

This is the #1 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. ** 

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. ** 

Repository breakdown:
* try: 39
* mozilla-central: 63
* autoland: 150
* mozilla-inbound: 199

Platform breakdown:
* linux64-nightly: 2
* windows7-32-msvc: 6
* windows7-32: 74
* windows7-32-nightly: 1
* linux32: 56
* macosx64-nightly: 9
* windows10-64-nightly: 1
* linux64-devedition: 2
* windows10-64: 85
* windows10-64-devedition: 1
* linux64: 93
* windows10-64-msvc: 4
* macosx64-devedition: 2
* linux32-nightly: 3
* osx-10-10: 112

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1482494&startday=2018-08-13&endday=2018-08-19&tree=all

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a097b1bacf9
Disable browser_urlbarSearchFunction.js for frequent failures. r=jmaher

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5a097b1bacf9

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

:Gijs, this is the other bug that made it hard to investigate and see failures in bug 1453723- again, this was recently disabled.

Comment 13

[Intermittent Failures Robot]

93 failures in 2568 pushes (0.036 failures/push) were associated with this bug in the last 7 days.

This is the #19 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. ** 

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. ** 

Repository breakdown:
* mozilla-central: 17
* try: 5
* mozilla-inbound: 17
* autoland: 54

Platform breakdown:
* linux64: 25
* windows10-64-msvc: 1
* windows7-32: 23
* windows10-64-ccov: 1
* macosx64-nightly: 1
* linux32: 7
* linux64-devedition: 1
* osx-10-10: 14
* windows10-64: 17
* windows7-32-msvc: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1482494&startday=2018-08-20&endday=2018-08-26&tree=all

Comment 14

[:Gijs (he/him)]

Sorry, haven't been able to make time here. However, I suspect the fix in bug 1485746 might fix this, too? Marco?

Comment 15

[Drew Willcoxon :adw]

I'll look at this, so I'm clearing Marco's NI and leaving mine, I'm just a little chafed at being on the hook for fixing it when I didn't break it

Comment 16

[Marco Bonardo [:mak]]

I wonder if the problem is similar to the other frequent failure we had, the test is not opening a new tab to run, but the harness is. When the harness opens a new tab it immediately starts running the test, but onLocationChange didn't fire yet, so you set the value to "basic", but immediately after it gets reset to the empty string.

I can push to Try and see if my theory is valid, by running the test in a new tab.

Comment 17

[Marco Bonardo [:mak]]

Attachment: Bug 1482494 - Intermittent failure in browser_urlbarSearchFunction.js

Comment 18

[Marco Bonardo [:mak]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=64341a257a6ae3062ec54e7cc1512092dee617f9&group_state=expanded

Comment 19

[Drew Willcoxon :adw]

Comment on attachment 9006889 [details]
Bug 1482494 - Intermittent failure in browser_urlbarSearchFunction.js

Drew Willcoxon :adw has approved the revision.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cf474bee0be
Intermittent failure in browser_urlbarSearchFunction.js r=adw

Comment 21

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4cf474bee0be

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2e81606ad203