Closed Bug 1482494 Opened 4 years ago Closed 4 years ago

Intermittent browser/base/content/test/urlbar/browser_urlbarSearchFunction.js | "" == "basic" - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/urlbar/browser_urlbarSearchFunction.js :: assertUrlbarValue :: line 210


(Firefox :: Address Bar, defect, P5)




Firefox 64
Tracking Status
firefox63 --- fixed
firefox64 --- fixed


(Reporter: intermittent-bug-filer, Assigned: mak)


(Keywords: intermittent-failure, Whiteboard: [retriggered][stockwell disabled])


(2 files)

Filed by: btara [at]

07:24:14     INFO - TEST-START | browser/base/content/test/urlbar/browser_urlbarSearchFunction.js
07:24:15     INFO - TEST-INFO | started process screencapture
07:24:15     INFO - TEST-INFO | screencapture: exit 0
07:24:15     INFO - Buffered messages logged at 07:24:14
07:24:15     INFO - Entering test bound init
07:24:15     INFO - Leaving test bound init
07:24:15     INFO - Entering test bound basic
07:24:15     INFO - Buffered messages logged at 07:24:15
07:24:15     INFO - Restore popup dontAnimate value to false
07:24:15     INFO - Buffered messages finished
07:24:15     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/urlbar/browser_urlbarSearchFunction.js | "" == "basic" - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/urlbar/browser_urlbarSearchFunction.js :: assertUrlbarValue :: line 210
07:24:15     INFO - Stack trace:
07:24:15     INFO - chrome://mochitests/content/browser/browser/base/content/test/urlbar/browser_urlbarSearchFunction.js:assertUrlbarValue:210
07:24:15     INFO - chrome://mochitests/content/browser/browser/base/content/test/urlbar/browser_urlbarSearchFunction.js:basic:34
07:24:15     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1106
07:24:15     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
07:24:15     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:999
07:24:15     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
07:24:15     INFO - TEST-PASS | browser/base/content/test/urlbar/browser_urlbarSearchFunction.js | true == true -
This test was introduced with this changeset: but did not start failing on that push

It was first classified over here and retriggering around that time showed up that it began failing with this push from Johann where it failed 6 times out of 20 -

Johann, can you please take a look over this? Thank you.
Flags: needinfo?(jhofmann)
Whiteboard: [retriggered]
Well my patch touches a bit of stuff in the identity block, which is of course in close proximity to the urlbar, but I can't imagine that the root cause for the intermittentness lies in my patch. Drew, do you have any idea what this is? I'm generally happy to support the effort here but I have no idea what this test does or why code touching the identity block should affect it.
Flags: needinfo?(jhofmann) → needinfo?(adw)
There are 358 failures in the last 7 days.
Attached a patch to disable the test until the issue will be fixed
Attachment #9002156 - Flags: review?(jmaher)
Attachment #9002156 - Flags: review?(jmaher) → review+
Whiteboard: [retriggered][stockwell disable-recommended] → [retriggered][stockwell disabled]
Pushed by
Disable browser_urlbarSearchFunction.js for frequent failures. r=jmaher
Keywords: checkin-needed
:Gijs, this is the other bug that made it hard to investigate and see failures in bug 1453723- again, this was recently disabled.
Flags: needinfo?(gijskruitbosch+bugs)
Sorry, haven't been able to make time here. However, I suspect the fix in bug 1485746 might fix this, too? Marco?
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(mak77)
I'll look at this, so I'm clearing Marco's NI and leaving mine, I'm just a little chafed at being on the hook for fixing it when I didn't break it
Assignee: nobody → adw
Flags: needinfo?(mak77)
I wonder if the problem is similar to the other frequent failure we had, the test is not opening a new tab to run, but the harness is. When the harness opens a new tab it immediately starts running the test, but onLocationChange didn't fire yet, so you set the value to "basic", but immediately after it gets reset to the empty string.

I can push to Try and see if my theory is valid, by running the test in a new tab.
Assignee: adw → mak77
Comment on attachment 9006889 [details]
Bug 1482494 - Intermittent failure in browser_urlbarSearchFunction.js

Drew Willcoxon :adw has approved the revision.
Attachment #9006889 - Flags: review+
Pushed by
Intermittent failure in browser_urlbarSearchFunction.js r=adw
Closed: 4 years ago
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.