Closed Bug 1482496 Opened 2 years ago Closed 2 years ago

wptmanifest doesn't support lists on the RHS of conditionals

Categories

(Testing :: web-platform-tests, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jgraham, Assigned: jgraham)

References

Details

Attachments

(1 file)

The grammar as implemented is effectively

"if " expr ":" string

When it should be

"if " expr ":" value

The latter in particular allows expressions like

prop:
  if foo: [1,2,3]
We were previously considering the grammar for conditionals in wpt
manifests to be something like:

"if " expr ":" string

This excluded the possibilty of complex values on the RHS. Here we
change it to the more obvious (and intended)

"if " expr ":" value

MozReview-Commit-ID: G6YWscW9dJS
Comment on attachment 8999278 [details]
Bug 1482496 - Support list values in wptmanifest conditionals, r=ato

Andreas Tolfsen ﹝:ato﹞ has approved the revision.
Attachment #8999278 - Flags: review+
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/ae52877671ad
Support list values in wptmanifest conditionals, r=ato
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12521 for changes under testing/web-platform/tests
https://hg.mozilla.org/mozilla-central/rev/ae52877671ad
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Assignee: nobody → james
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf6017cb3dbe
[wpt PR 12521] - [Gecko Bug 1482496] Support list values in wptmanifest conditionals, a=testonly
You need to log in before you can comment on or make changes to this bug.