1482496 - wptmanifest doesn't support lists on the RHS of conditionals

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Description

[James Graham [:jgraham]]

The grammar as implemented is effectively

"if " expr ":" string

When it should be

"if " expr ":" value

The latter in particular allows expressions like

prop:
  if foo: [1,2,3]

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1482496 - Support list values in wptmanifest conditionals, r=ato

We were previously considering the grammar for conditionals in wpt
manifests to be something like:

"if " expr ":" string

This excluded the possibilty of complex values on the RHS. Here we
change it to the more obvious (and intended)

"if " expr ":" value

MozReview-Commit-ID: G6YWscW9dJS

Comment 2

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8999278 [details]
Bug 1482496 - Support list values in wptmanifest conditionals, r=ato

Andreas Tolfsen ﹝:ato﹞ has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae52877671ad
Support list values in wptmanifest conditionals, r=ato

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12521 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/12521
* continuous-integration/travis-ci/pr (https://travis-ci.org/web-platform-tests/wpt/builds/416749532?utm_source=github_status&utm_medium=notification)

Comment 6

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/ae52877671ad

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf6017cb3dbe
[wpt PR 12521] - [Gecko Bug 1482496] Support list values in wptmanifest conditionals, a=testonly

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cf6017cb3dbe