Closed Bug 1482560 Opened 2 years ago Closed 2 years ago

Tracelogger: allow traceLogger to record events without writing to disk

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: denispal, Assigned: denispal)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

It is not currently possible to record events by the traceLogger without also writing the events to disk.  We'll need to decouple these two actions as a first step to hooking up the traceLogger to the gecko profiler since we need to keep this data in memory and not flush to disk.
Assignee: nobody → dpalmeiro
When enabling the tracelogger, it will automatically spew the data to disk in the location specified by TLDIR or /tmp, if undefined.  However, there needs to be a way to enable the tracelogger without spewing so that we can write this data as part of the gecko profiler JSON output, and ultimately visualized with perf.html.
Comment on attachment 8999314 [details]
Bug 1482560: Do not flush tracelogger to disk unless specifically requested to do so

Guessing that a review is wanted here.
Attachment #8999314 - Flags: review?(sphink)
Priority: -- → P3
(In reply to Jason Orendorff [:jorendorff] from comment #2)
> Comment on attachment 8999314 [details]
> Bug 1482560: Do not flush tracelogger to disk unless specifically requested
> to do so
> 
> Guessing that a review is wanted here.

Yes, I was planning to chain this up to a couple other reviews (bug 1480104 & another one I will open about connecting the TL to the gecko profiler) so the context would be more clear so I left the reviewers list empty for now.  However, this piece is independent enough that a review now is also welcome!
Blocks: 1480104
Comment on attachment 8999314 [details]
Bug 1482560: Do not flush tracelogger to disk unless specifically requested to do so

Steve Fink [:sfink] [:s:] has approved the revision.
Attachment #8999314 - Flags: review+
Thanks for the review, sfink!
Keywords: checkin-needed
Lando says this can't land because it depends on D3683.
Flags: needinfo?(dpalmeiro)
Keywords: checkin-needed
Thanks, sorry I fixed it now.  It should be the other way around, so I guess D3683 should maybe be a child revision instead of parent..
Flags: needinfo?(dpalmeiro)
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c8443454c325
Do not flush tracelogger to disk unless specifically requested to do so r=sfink
https://hg.mozilla.org/mozilla-central/rev/c8443454c325
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment on attachment 8999314 [details]
Bug 1482560: Do not flush tracelogger to disk unless specifically requested to do so

I think this had a stale r? (probably because phabricator stopped mirroring the review state?)
Attachment #8999314 - Flags: review?(sphink) → review+
Blocks: 1501377
You need to log in before you can comment on or make changes to this bug.