1482560 - Tracelogger: allow traceLogger to record events without writing to disk

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Denis Palmeiro [:denispal]]

It is not currently possible to record events by the traceLogger without also writing the events to disk.  We'll need to decouple these two actions as a first step to hooking up the traceLogger to the gecko profiler since we need to keep this data in memory and not flush to disk.

Comment 1

[Denis Palmeiro [:denispal]]

Attachment: Bug 1482560: Do not flush tracelogger to disk unless specifically requested to do so

When enabling the tracelogger, it will automatically spew the data to disk in the location specified by TLDIR or /tmp, if undefined.  However, there needs to be a way to enable the tracelogger without spewing so that we can write this data as part of the gecko profiler JSON output, and ultimately visualized with perf.html.

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 8999314 [details]
Bug 1482560: Do not flush tracelogger to disk unless specifically requested to do so

Guessing that a review is wanted here.

Comment 3

[Denis Palmeiro [:denispal]]

(In reply to Jason Orendorff [:jorendorff] from comment #2)
> Comment on attachment 8999314 [details]
> Bug 1482560: Do not flush tracelogger to disk unless specifically requested
> to do so
> 
> Guessing that a review is wanted here.

Yes, I was planning to chain this up to a couple other reviews (bug 1480104 & another one I will open about connecting the TL to the gecko profiler) so the context would be more clear so I left the reviewers list empty for now.  However, this piece is independent enough that a review now is also welcome!

Comment 4

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8999314 [details]
Bug 1482560: Do not flush tracelogger to disk unless specifically requested to do so

Steve Fink [:sfink] [:s:] has approved the revision.

Comment 5

[Denis Palmeiro [:denispal]]

Thanks for the review, sfink!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Lando says this can't land because it depends on D3683.

Comment 7

[Denis Palmeiro [:denispal]]

Thanks, sorry I fixed it now.  It should be the other way around, so I guess D3683 should maybe be a child revision instead of parent..

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8443454c325
Do not flush tracelogger to disk unless specifically requested to do so r=sfink

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c8443454c325

Comment 10

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8999314 [details]
Bug 1482560: Do not flush tracelogger to disk unless specifically requested to do so

I think this had a stale r? (probably because phabricator stopped mirroring the review state?)