Closed Bug 1482594 Opened 2 years ago Closed 2 years ago
Implement Firefox Monitor popup notification UI
In this bug my goal is to land code for showing a PopupNotification when a breached site is visited. That includes: - Code for observing windows and injecting popup notification UI and styles - Code for triggering a popup notification when needed - L10n support - Code to keep this pref'd off I do NOT plan to cover in THIS bug: - Fetching actual breach data from HIBP
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
One thing not mentioned in comment 0 is that this patch does not add telemetry yet. I plan to do that in a follow-up. There are some TODO comments in the code, but they are either not going to be covered in this bug or are minor - so I didn't see any reason not to start getting this reviewed. I've also asked UX a few questions so I may be updating this patch when they respond - but I didn't want to wait for that to get this up. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac645faf074f9ff11ac882ce0761f056fa4c4ed1 I will request r? once I have a green try run.
Attachment #8999323 - Attachment is obsolete: true
Previous patch was broken, fixed and added some improvements. New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a196f6ec33c28ce99bced7e00ef32af67a5f8d58
Attachment #8999803 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.