Closed
Bug 1482753
Opened 6 years ago
Closed 6 years ago
Need a way to write a new HAL observer handy
Categories
(Core :: Hardware Abstraction Layer (HAL), enhancement)
Core
Hardware Abstraction Layer (HAL)
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
References
Details
Attachments
(4 files)
I was going to add a new HAL observer for input devices changes for bug 1035774, and realized that adding it is painful because most of the code will look similar to pre-existing observers.
I did try to make it bit handy.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8accbec654421c55b3809c54d2c488af2d359195
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Depends on D3179
Assignee | ||
Comment 3•6 years ago
|
||
Depends on D3180
Assignee | ||
Comment 4•6 years ago
|
||
If `ScreenConfiguration` were `ScreenInformation` we could integrate
notification functions into the macros too.
Depends on D3181
Updated•6 years ago
|
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
Comment 5•6 years ago
|
||
Very nice! I was doing some cleanup in bug 1476250 myself but I'll rebase it on this as it will make things simpler.
Blocks: 1476250
Comment 6•6 years ago
|
||
Comment on attachment 8999484 [details]
Bug 1482753 - Move network/Types.h into hal/ and NetworkObserver into hal namespace. r=gsvelto
Gabriele Svelto [:gsvelto] has approved the revision.
Attachment #8999484 -
Flags: review+
Comment 7•6 years ago
|
||
Comment on attachment 8999485 [details]
Bug 1482753 - Move battery/Types.h into hal/ and BatteryObserver into hal namespace. r=gsvelto
Gabriele Svelto [:gsvelto] has approved the revision.
Attachment #8999485 -
Flags: review+
Comment 8•6 years ago
|
||
Comment on attachment 8999486 [details]
Bug 1482753 - Move power/Types.h into hal/ and WakeLockObserver into hal namespace. r=gsvelto
Gabriele Svelto [:gsvelto] has approved the revision.
Attachment #8999486 -
Flags: review+
Comment 9•6 years ago
|
||
Comment on attachment 8999487 [details]
Bug 1482753 - Introduce two macros to implement HAL observers handy. r=gsvelto
Gabriele Svelto [:gsvelto] has approved the revision.
Attachment #8999487 -
Flags: review+
Comment 10•6 years ago
|
||
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f7c6b1dae39
Move network/Types.h into hal/ and NetworkObserver into hal namespace. r=gsvelto
https://hg.mozilla.org/integration/mozilla-inbound/rev/586c439c9a0d
Move battery/Types.h into hal/ and BatteryObserver into hal namespace. r=gsvelto
https://hg.mozilla.org/integration/mozilla-inbound/rev/8741c8f1eaa6
Move power/Types.h into hal/ and WakeLockObserver into hal namespace. r=gsvelto
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9c1a36c4f41
Introduce two macros to implement HAL observers handy. r=gsvelto
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0f7c6b1dae39
https://hg.mozilla.org/mozilla-central/rev/586c439c9a0d
https://hg.mozilla.org/mozilla-central/rev/8741c8f1eaa6
https://hg.mozilla.org/mozilla-central/rev/c9c1a36c4f41
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•