Closed Bug 1482753 Opened 6 years ago Closed 6 years ago

Need a way to write a new HAL observer handy

Categories

(Core :: Hardware Abstraction Layer (HAL), enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

Details

Attachments

(4 files)

I was going to add a new HAL observer for input devices changes for bug 1035774, and realized that adding it is painful because most of the code will look similar to pre-existing observers. I did try to make it bit handy. https://treeherder.mozilla.org/#/jobs?repo=try&revision=8accbec654421c55b3809c54d2c488af2d359195
If `ScreenConfiguration` were `ScreenInformation` we could integrate notification functions into the macros too. Depends on D3181
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
Very nice! I was doing some cleanup in bug 1476250 myself but I'll rebase it on this as it will make things simpler.
Blocks: 1476250
Comment on attachment 8999484 [details] Bug 1482753 - Move network/Types.h into hal/ and NetworkObserver into hal namespace. r=gsvelto Gabriele Svelto [:gsvelto] has approved the revision.
Attachment #8999484 - Flags: review+
Comment on attachment 8999485 [details] Bug 1482753 - Move battery/Types.h into hal/ and BatteryObserver into hal namespace. r=gsvelto Gabriele Svelto [:gsvelto] has approved the revision.
Attachment #8999485 - Flags: review+
Comment on attachment 8999486 [details] Bug 1482753 - Move power/Types.h into hal/ and WakeLockObserver into hal namespace. r=gsvelto Gabriele Svelto [:gsvelto] has approved the revision.
Attachment #8999486 - Flags: review+
Comment on attachment 8999487 [details] Bug 1482753 - Introduce two macros to implement HAL observers handy. r=gsvelto Gabriele Svelto [:gsvelto] has approved the revision.
Attachment #8999487 - Flags: review+
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0f7c6b1dae39 Move network/Types.h into hal/ and NetworkObserver into hal namespace. r=gsvelto https://hg.mozilla.org/integration/mozilla-inbound/rev/586c439c9a0d Move battery/Types.h into hal/ and BatteryObserver into hal namespace. r=gsvelto https://hg.mozilla.org/integration/mozilla-inbound/rev/8741c8f1eaa6 Move power/Types.h into hal/ and WakeLockObserver into hal namespace. r=gsvelto https://hg.mozilla.org/integration/mozilla-inbound/rev/c9c1a36c4f41 Introduce two macros to implement HAL observers handy. r=gsvelto
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: