1482783 - [remote-dbg-next] Reduce duplicated code for current and new about:debugging

Status: RESOLVED DUPLICATE of bug 1487078

(DevTools :: about:debugging, enhancement)

Description

[Daisuke Akatsuka (:daisuke)]

There are codes where we copied and are using of current about:debugging in new one. For example current[1], new[2]. And we will copy the current code[3] to new one in bug 1477598.
So, we need to reduce the duplicated code using shared module and so on for both about:debugging, since we have to care two places always.


[1] https://searchfox.org/mozilla-central/source/devtools/client/aboutdebugging/components/tabs/Panel.js#62
[2] https://searchfox.org/mozilla-central/source/devtools/client/aboutdebugging-new/src/reducers/runtime-state.js#45
[3] https://searchfox.org/mozilla-central/source/devtools/client/aboutdebugging/modules/addon.js#98

Comment 1

[Julian Descottes [:jdescottes]]

The urls above are no longer valid. 

Note that addons code has been mutualized already in Bug 1487078.

Potential areas with code duplication remaining:
- retrieving and inspecting other debug targets (everything under devtools/client/aboutdebugging-new/src/actions/debug-targets.js)
- local and remote client creation
https://searchfox.org/mozilla-central/rev/0640ea80fbc8d48f8b197cd363e2535c95a15eb3/devtools/client/aboutdebugging-new/src/actions/runtimes.js#33-57

Comment 2

[Julian Descottes [:jdescottes]]

I reviewed the remaining code duplication and I don't think there is anything really interesting to share anymore. We have some common code between devtools/client/aboutdebugging-new/src/actions/runtimes.js and devtools/client/framework/target-from-url.js, but it is just a few lines of code to create either a local or a network transport. For devtools/client/aboutdebugging-new/src/actions/debug-targets.js, we are mostly delegating to the client.

I propose to close this in favor of Bug 1487078 which addressed the main duplication for related to addons.
Daisuke, what do you think about this?

Comment 3

[Daisuke Akatsuka (:daisuke)]

Thanks Julian!
Yeah, also we have reduced the duplication in each bug :)
Yes, let us close this.