Closed Bug 1482808 Opened 2 years ago Closed 2 years ago

Clear the field-specific merchant error invalid state when the field has been edited

Categories

(Firefox :: WebPayments UI, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 64
Tracking Status
firefox64 --- verified

People

(Reporter: MattN, Assigned: jaws)

References

Details

(Whiteboard: [webpayments])

Attachments

(2 files)

"Once the user begins to type into a field with an in-context error, the error will disappear. This will also work if a user deletes text within the field."

https://mozilla.invisionapp.com/share/YAFI31XR3KP#/screens/275361828

Right now https://dxr.mozilla.org/mozilla-central/rev/4e56a2f51ad739ca52046723448f3129a58f1666/browser/components/payments/test/browser/browser_shippingaddresschange_error.js#158 will hang after bug 1476345 disables the save button if there are invalid field because setCustomValidity is called with merchant-specific errors call but they are never cleared.
Flags: qe-verify+
Priority: -- → P2
QA Contact: hani.yacoub
Whiteboard: [webpayments] [triage] → [webpayments-reserve]
Whiteboard: [webpayments-reserve] → [webpayments]
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 9006701 [details]
Bug 1482808 - Clear the field-specific merchant error invalid state when the field has been edited. r?sfoster

Sam Foster [:sfoster] has approved the revision.
Attachment #9006701 - Flags: review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f669be991db6
Clear the field-specific merchant error invalid state when the field has been edited. r=sfoster
https://hg.mozilla.org/mozilla-central/rev/f669be991db6
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Attached image error.png
I'm not sure when the in-context error will be displayed, to try to verify when the error will disappear.

I accessed "https://rsolomakhin.github.io/pr/single/" (FTU), entered valid data in every field except "ZIP Code" field, no in-context error is displayed, only a red outline. (Please see screenshot attached)
Flags: needinfo?(jaws)
This bug only focused on shipping address errors that are supplied by the merchant after the user changes their shipping address. I'm not sure of a website that implements this yet because it was just added to the spec.

The error text for the zip code will appear in a tooltip if you hover over the field. We should probably have that message show up in a popup the same way as the merchant specific address fields. I've filed bug 1490077 to display these the same.
Flags: needinfo?(jaws)
Since bug 1490077 introduced the field-specific errors, the red popup will disappear after the user edited the incorrect data.

The same behavior was observed for the merchant errors that appear on the summary page after editing the invalid Shipping address or saved CC. 

Is this check enough to cover this issue fix?
Flags: needinfo?(jaws)
Yes, it is. Thanks.
Flags: needinfo?(jaws)
Thanks Jared!

Based on Comment 7 and Comment 8, I will mark this issues as Verified - Fixed  on Windows 10/7, Mac OS 10.13 and Ubuntu 16.04.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Depends on: 1495549
You need to log in before you can comment on or make changes to this bug.