Closed Bug 1482809 Opened Last year Closed 7 months ago

consider moving non-browser specific parts of browser/components/enterprisepolicies to toolkit

Categories

(Firefox :: Enterprise Policies, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox63 --- wontfix
firefox68 --- fixed

People

(Reporter: mkmelin, Assigned: darktrojan)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1419102 +++

There are a bunch of functionality that doesn't appear to be very browser-specific in https://dxr.mozilla.org/mozilla-central/source/browser/components/enterprisepolicies

Policies.jsm is pretty Firefox-centric, but e.g. WindowsGPOParser.jsm and content/ProxyPolicies.jsm as well as EnterprisePolicies.js and EnterprisePoliciesContent.js look like general level utilities (with a few lines parameterized).

These would be useful for Thunderbird too as we'll need policies to allow disabling auto-update (and more, going forwards I assume). xref bug 1420514.

Could we consider moving relevant code to toolkit? nsIEnterprisePolicies.idl is already there.
We would certainly take a patch, but this isn't something we're going to be able to prioritize.

We have more work than we know what to do with.

I'm removing most of the CCs because the clone put them in here.
Priority: P1 → P5
Assignee: nobody → geoff
Blocks: 1461330

geoff:

What are your plans for checking this in?

Do you want to do a try run first just in case?

Geoff is offline for some days, so I've went ahead and pushed to try now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d24b53a4ea7dac9a2c54e68dfd6b261cb2c64990

Status: NEW → ASSIGNED

The commit message lacks the "Bug 1482809 - " but other than that the try looks ok to me.

Is the commit message editable in phab? Let's get it landed.

Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/28b3bd8e5018
Move non-browser-specific parts of browser/components/enterprisepolicies to toolkit r=mkaply,Felipe

Argh. I accidentally put you (Magnus) as the author because I saw your name everywhere in the bug...

Backed out changeset 28b3bd8e5018 (bug 1482809) for using the wrong author.

Backout link: https://hg.mozilla.org/integration/autoland/rev/944e6bb582152425581c9764c6ebe70fdb554968

Flags: needinfo?(mozilla)

Thanks Raul. I've already updated and have the new patch. Sorry for the hassle.

Flags: needinfo?(mozilla)
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/0f5b654fe33f
Move non-browser-specific parts of browser/components/enterprisepolicies to toolkit r=mkaply,Felipe
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.