1482850 - Crash in MimeDecoderWrite

Status: RESOLVED DUPLICATE of bug 1876127

(MailNews Core :: MIME, defect)

Description

[Wayne Mery (:wsmwk)]

Odd aspect of this crash, is 50% are from linux users. Most crash comments (which happen to be linux) mention forwarding an email [1].

And the Windows crash stacks are different [2].


This bug was filed from the Socorro interface and is
report bp-cf68005a-1145-446d-8ef7-d19a90180625 Markus on linux was using a template
linux crashes all have mime_decompose_file_output_fn in frame 1

=============================================================

Top 10 frames of crashing thread:

0 libxul.so MimeDecoderWrite /build/thunderbird-LBvV1r/thunderbird-52.8.0+build1/mailnews/mime/src/mimeenc.cpp:156
1 libxul.so mime_decompose_file_output_fn /build/thunderbird-LBvV1r/thunderbird-52.8.0+build1/mailnews/mime/src/mimedrft.cpp:1916
2 libxul.so MimeMessage_parse_line /build/thunderbird-LBvV1r/thunderbird-52.8.0+build1/mailnews/mime/src/mimemsg.cpp:202
3 libxul.so MimeObject_parse_eof /build/thunderbird-LBvV1r/thunderbird-52.8.0+build1/mailnews/mime/src/mimeobj.cpp:270
4 libxul.so MimeContainer_parse_eof /build/thunderbird-LBvV1r/thunderbird-52.8.0+build1/mailnews/mime/src/mimecont.cpp:97
5 libxul.so MimeMessage_parse_eof /build/thunderbird-LBvV1r/thunderbird-52.8.0+build1/mailnews/mime/src/mimemsg.cpp:565
6 libxul.so mime_parse_stream_complete /build/thunderbird-LBvV1r/thunderbird-52.8.0+build1/mailnews/mime/src/mimedrft.cpp:1132
7 libxul.so nsStreamConverter::OnStopRequest /build/thunderbird-LBvV1r/thunderbird-52.8.0+build1/mailnews/mime/src/nsStreamConverter.cpp:1055
8 libxul.so nsImapCacheStreamListener::OnStopRequest /build/thunderbird-LBvV1r/thunderbird-52.8.0+build1/mailnews/imap/src/nsImapProtocol.cpp:8916
9 libxul.so nsInputStreamPump::OnStateStop /build/thunderbird-LBvV1r/thunderbird-52.8.0+build1/mozilla/netwerk/base/nsInputStreamPump.cpp:714

=============================================================

[1] forward mentioned in comments:
bp-d54c9155-1415-4132-b99e-062850180422 Mac 45.8.0
bp-e9b19f41-2ffc-4edb-9e47-150a20180219 linux 59.0b1
bp-3b8d6ce7-0f8a-4b80-a649-09b390180215 linux 52.6.0

[2] Windows crashes: bp-0ba569a3-5e5a-4897-839c-c2cab0180618 bp-9ac3965c-d802-473e-b38f-ea8000180702

Comment 1

[Wayne Mery (:wsmwk)]

There are no version 60 crashes since June. Let's see what happens after v60 updates are  unthrottled

Comment 2

[Wayne Mery (:wsmwk)]

There are v60 crashes, so this needs another look

Comment 3

[Wayne Mery (:wsmwk)]

Still rare v60 crashes

Comment 4

[Wayne Mery (:wsmwk)]

Still rare of course (2 crashes per day only) but no linux crashes

Comment 5

[Wayne Mery (:wsmwk)]

In version 68 this is no longer rare. Perhaps what is happening in version 68 is entirely different from prior versions, and we have a regression? We did have quite a few mime fixes along the way https://mzl.la/2RbXIPY

bp-3e2d7513-fabc-4fd4-8352-a9ff60200404
0 xul.dll MimeDecoderWrite(MimeDecoderData*, char const*, int, int*) comm/mailnews/mime/src/mimeenc.cpp:744 context
1 xul.dll mime_decompose_file_output_fn(char const*, int, void*) comm/mailnews/mime/src/mimedrft.cpp:1929 cfi
2 xul.dll static int MimeMessage_parse_line(const char*, int, struct MimeObject*) comm/mailnews/mime/src/mimemsg.cpp:170 cfi
3 xul.dll static int MimeObject_parse_eof(struct MimeObject*, bool) comm/mailnews/mime/src/mimeobj.cpp:247 cfi
4 xul.dll static int MimeContainer_parse_eof(struct MimeObject*, bool) comm/mailnews/mime/src/mimecont.cpp:85 cfi
5 xul.dll static int MimeMessage_parse_eof(struct MimeObject*, bool) comm/mailnews/mime/src/mimemsg.cpp:492 cfi
6 xul.dll static void mime_parse_stream_complete(struct _nsMIMESession*) comm/mailnews/mime/src/mimedrft.cpp:1157 cfi
7 xul.dll nsStreamConverter::OnStopRequest(nsIRequest*, nsresult) comm/mailnews/mime/src/nsStreamConverter.cpp:922 cfi
8 xul.dll nsMsgProtocol::OnStopRequest(nsIRequest*, nsresult) comm/mailnews/base/util/nsMsgProtocol.cpp:384 cfi
9 xul.dll nsMailboxProtocol::OnStopRequest(nsIRequest*, nsresult) comm/mailnews/local/src/nsMailboxProtocol.cpp:384 cfi
10 xul.dll nsInputStreamPump::OnStateStop() netwerk/base/nsInputStreamPump.cpp:655 cfi

bp-b4db3cef-7919-4ef9-b457-defe10200403
bp-b673a7de-d081-40a1-88ee-f99470200403
bp-c4dc055c-7767-49c7-b0a3-d4eb90200403

Comment 6

[Magnus Melin [:mkmelin]]

Crash at https://searchfox.org/comm-central/rev/89f79029d9792b8d42ef9cc5cfe725cc0c333b13/mailnews/mime/src/mimeenc.cpp#744 - but I don't see how.

Comment 7

[Wayne Mery (:wsmwk)]

steady crash rate last 6 month
bp-e9322de8-6890-4d0d-ad03-c3ffb0210101
0 xul.dll MimeDecoderWrite(MimeDecoderData*, char const*, int, int*) comm/mailnews/mime/src/mimeenc.cpp:744
1 xul.dll mime_decompose_file_output_fn(char const*, int, void*) comm/mailnews/mime/src/mimedrft.cpp:1929
2 xul.dll MimeMessage_parse_line(char const*, int, MimeObject*) comm/mailnews/mime/src/mimemsg.cpp:169
3 xul.dll MimeObject_parse_eof(MimeObject*, bool) comm/mailnews/mime/src/mimeobj.cpp:247
4 xul.dll MimeContainer_parse_eof(MimeObject*, bool) comm/mailnews/mime/src/mimecont.cpp:85
5 xul.dll MimeMessage_parse_eof(MimeObject*, bool) comm/mailnews/mime/src/mimemsg.cpp:491
6 xul.dll mime_parse_stream_complete(_nsMIMESession*) comm/mailnews/mime/src/mimedrft.cpp:1157
7 xul.dll nsStreamConverter::OnStopRequest(nsIRequest*, nsresult) comm/mailnews/mime/src/nsStreamConverter.cpp:921
8 xul.dll nsMsgProtocol::OnStopRequest(nsIRequest*, nsresult) comm/mailnews/base/src/nsMsgProtocol.cpp:386
9 xul.dll nsMailboxProtocol::OnStopRequest(nsIRequest*, nsresult) comm/mailnews/local/src/nsMailboxProtocol.cpp:384
10 xul.dll nsInputStreamPump::OnStateStop() netwerk/base/nsInputStreamPump.cpp:649

Comment 8

[Wayne Mery (:wsmwk)]

Attachment: image.png

Still a strong crash at the time that crash-stats stopped accepting Thunderbird crashes

Comment 9

[Wayne Mery (:wsmwk)]

#18 crash for version 102
bp-51ae4a3c-aa58-40e6-b58a-03e170220725 v91
bp-a3ef3038-e2ac-4faa-9d94-b2c980220723 v102

Comment 10

[Wayne Mery (:wsmwk)]

Current crash rank of #48 doesn't warrant severity S2

Comment 11

[Wayne Mery (:wsmwk)]

Perhaps the following are more helpful?

• Bp-e9ed7f3c-5446-46df-b509-f8ef00230524 "Attempting to forward a message that is somehow corrupted (most likely errors during synchronization with IMAP server)"
• bp-1938d747-9eb6-4664-9166-12bdd023052 "Crashing each time I try to use a draft folder draft"
• bp-c8d8010b-74ec-4085-80a2-d91ff0230525 "Happened twice when clicking "new message from template""
• bp-764e9f20-64c1-4177-b7f5-3de9d0230509 "forwarding message from PayPal"

Comment 12

[Wayne Mery (:wsmwk)]

And bp-554b5c69-0c2f-4883-afca-0e6d60230124 talks about a message being flagged by bitdefender.

Comment 13

[Magnus Melin [:mkmelin]]

Unfortunately the crash stacks are not that helpful. https://hg.mozilla.org/releases/comm-esr102/file/tip/mailnews/mime/src/mimeenc.cpp#l753