1482865 - @searches Top Sites from the "Add Search Engines" menu overlap when the browser is horizontally resized

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: @searches top sites overlap.gif

[Affected versions]:
- Nightly v63.0a1, Build ID 20180812220618

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Steps to reproduce]:
1. Open the browser with a clean new profile.
2. Click the "..." Top Sites section button and click the "Add Search Engine" option.
3. Resize the browser to a quarter screen.
4. Observe the behavior.

[Expected results]:
- The @searches Top Sites are displayed in a grid.

[Actual results]:
- One of the @searches Top Site overlaps the one before it.

[Notes]:
- Attached a screen recording of the issue.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4327

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/5fe21cda2ba9ad87cc7530211e3f41833768bff0
Fix Bug 1482865 - fix searchy overlap when resizing window

https://github.com/mozilla/activity-stream/commit/f97fcb054e587da732b1b6daea1daf217865a36b
Merge pull request #4327 from rlr/bug1482865/overlap-fix

Fix Bug 1482865 - fix searchy overlap when resizing window

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/fcf8f41c1ae2

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e752b54a20f425449e1f00bf3adefa903f8051a

Comment 5

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible in the latest Nightly (63.0a1, Build ID 20180816100035) on Windows 10, Mac 10.13 and Arch Linux x64.

Comment 6

[Cristian Fogel [:cfogel]]

Fix confirmed for 62.0b18 on Windows 10x64, Ubuntu 18.04LTS, macOS10.13.