1482870 - Theme Experiments not applied to new windows

Status: VERIFIED FIXED

(WebExtensions :: Themes, defect, P5)

Description

[M8R-p7]

If it's too early to start filing bugs on Theme Experiments, just say the word.

STR:
0. Create a new profile and in 'about:config' set 'extensions.legacy.enabled' to 'true'.
1. Create or install a Theme Experiment, providing some experimental rules (one is provided).
2. Check that the Experiment's changes are visible (the Identity Box is a garish lime color).
3. Open a new window.

Actual Results:
The experiment's changes are not visible in the new window.
Any new variables aren't applied to the new window, and any stylesheets provided with the experiment are not loaded (a stylesheet isn't required to trigger this - it was just a more visible demonstration than many of the root variables not already covered).

Expected Results:
The experiment's changes should be visible in all future windows.

Comment 1

[M8R-p7]

Attachment: Bug demonstration XPI

Comment 2

[Tim Nguyen :ntim]

Thanks for reporting this. This seems like something we need to fix.

Comment 3

[Tim Nguyen :ntim]

The refactoring in bug 1525762 will make it easier to fix this.

Comment 4

[Tim Nguyen :ntim]

Attachment: Bug 1482870 - Make current theme experiment initialize in new windows.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de0a6c9a38a9
Make current theme experiment initialize in new windows. r=kmag

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/de0a6c9a38a9

Comment 7

[M8R-p7]

I now see the Expected Results in Nightly 68.0a1 2019-04-04. Thank you!