1482895 - The "Add Search Engine" overlay is not scrollable if the browser is horizontally resized to the minimum supported width

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: Add search engine can't be scrolled.gif

[Affected versions]:
- Nightly v63.0a1, Build ID 20180812220618

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Steps to reproduce]:
1. Open the browser with a clean new profile.
2. Click the "..." Top Sites section button and click the "Add Search Engine" option.
3. Resize the browser to the minimum supported width.
4. Scroll down the page and observe the behavior.

[Expected results]:
- The page is scrolled and the bottom part of the "Add Search Engine" overlay is displayed.

[Actual results]:
- The page in the background is scrolled, but the "Add Search Engine" is not.

[Notes]:
- The action can't be saved in this situation as the user does not have access to the "Save" button.
- Attached a screen recording of the issue.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4331

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/c9d3c708067397b7e88e420fcb005c7965c4fd18
Fix Bug 1482895 - scroll the modal on short windows (#4331)

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/fcf8f41c1ae2

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e752b54a20f425449e1f00bf3adefa903f8051a

Comment 5

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible in the latest Nightly (63.0a1, Build ID 20180816100035) on Windows 10, Mac 10.13 and Arch Linux x64.

Comment 6

[Oana Botisan, Desktop Release QA]

I managed to reproduce the issue using an older version of Nightly (2018-08-12) on Windows 10x64.
I retested everything using beta 62.0b19 on Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.12. The bug is not reproducing anymore.