1482898 - Make root requirement in mozdevice optional

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement)

Description

[William Lachance (:wlach)]

To support mozregression, which is mostly used with unrooted devices, we should make it possible to initialize ADB without root permissions (this was broken in bug 1440714).

Comment 1

[William Lachance (:wlach)]

Attachment: Patch to make root requirement optional

Comment 2

[Bob Clary [:bc] (inactive)]

Comment on attachment 8999626 [details] [diff] [review]
Patch to make root requirement optional

Review of attachment 8999626 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok to me. This is sufficient to allow mozregression to work? r+

Comment 3

[William Lachance (:wlach)]

(In reply to Bob Clary [:bc:] from comment #2)
> Comment on attachment 8999626 [details] [diff] [review]

> Looks ok to me. This is sufficient to allow mozregression to work? r+

I believe so, haven't tested mozregression itself but am 99% sure.

Here's a try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fe4935382c28742440da69ef00be0cfc85a0f81

Comment 4

[William Lachance (:wlach)]

Attachment: Patch to make root requirement optional

Adding a version bump to mozdevice, carrying forward r+

Comment 5

[William Lachance (:wlach)]

Try run looks good, can someone land this for me?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f69e8083284
Support running adb commands in mozdevice as non-root;r=bc

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/6f69e8083284

Comment 9

[William Lachance (:wlach)]

The above patch actually didn't quite fix things :( Sorry for the churn

Comment 10

[William Lachance (:wlach)]

Actually, I forgot that we should file followups if additional changes are asked for, I'll do that: bug 1483221