1482990 - Use different message names for inbound/outbound message between console and netmonitor actors.

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[Alexandre Poirot [:ochameau]]

Followup to bug 1479524:

(In reply to Julian Descottes [:jdescottes][:julian] from comment #8)
> Comment on attachment 8996280 [details]
> Bug 1479524 - Always use message manager with NetworkMonitorActor.
> ::: devtools/server/actors/network-monitor.js:145
> (Diff revision 4)
> >      }
> >    },
> >  
> >    onGetNetworkEventActor({ data }) {
> >      const actor = this.getNetworkEventActor(data.channelId);
> > -    this.messageManager.sendAsyncMessage("debug:get-network-event-actor", actor.form());
> > +    this.messageManager.sendAsyncMessage("debug:get-network-event-actor", {
> 
> Not related to your change, but I am a bit confused by the messages passed
> around with the message manager. If I understand correctly, the webconsole
> actor sends "debug:get-network-event-actor", here the network-monitor
> listens to this message and responds to is with another
> "debug:get-network-event-actor" but this time to return the result? Would it
> make sense to have different names here, maybe with kind of naming pattern?
> "debug:something-something-request" "debug:something-something-result"

Comment 1

[Alexandre Poirot [:ochameau]]

Green try:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ec6788db74cd3440ffd3c44dad8e4098a3497f8

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1482990 - Use different message names for inbound/outbound message between console and netmonitor actors. r=jdescottes

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 9004807 [details]
Bug 1482990 - Use different message names for inbound/outbound message between console and netmonitor actors. r=jdescottes

Julian Descottes [:jdescottes][:julian] has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6b4091debb4
Use different message names for inbound/outbound message between console and netmonitor actors. r=jdescottes

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/f6b4091debb4