1483025 - Search within Add-ons Manager stopped working

Status: VERIFIED FIXED

(Core :: DOM: Security, defect)

Description

[[:philipp]]

str in a new profile:
- open about:addons
- go to the extensions section
- type a query into the "search on addons.mozilla.org" field & hit enter

instead of opening a new tab with search results from amo nothing is happening and the browser console shows:
> Error: Required argument triggeringPrincipal missing within loadOneTab tabbrowser.js:1378:13

this regressed recently with bug 1362034.

Comment 2

[Jonathan Kingston [:jkt] he/him]

Attachment: Bug 1483025 - add in principal for about:addons search.

Comment 4

[:Gijs (he/him)]

Comment on attachment 9001640 [details]
Bug 1483025 - add in principal for about:addons search.

:Gijs (he/him) has approved the revision.

Comment 5

[Jonathan Kingston [:jkt] he/him]

I filed a follow up for the search opening in a new tab: https://bugzilla.mozilla.org/show_bug.cgi?id=1484717

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a72f317a470e
add in principal for about:addons search. r=Gijs

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a72f317a470e

Comment 8

[Victor Carciu]

Verified as fixed in FF 63.0a1 (20180821100053) using Windows10x64 and MacOS 10.13.2.

I will attach a postfix video.

Comment 9

[Victor Carciu]

Attachment: Postfix video