1483051 - Update to whitenoise 4

Status: RESOLVED FIXED

(Tree Management :: Treeherder, enhancement, P1)

Description

[Ed Morley [:emorley]]

WhiteNoise 4 has just been released, which includes a number of runtime and deploy time performance improvements (eg the time spent compressing static assets during collectstatic is halved, thanks to original file removal), and also adds features that now mean we can remove most of the customisations we make in our custom subclass.

See:
http://whitenoise.evans.io/en/stable/changelog.html#v4-0

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3916

Comment 2

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/67d09d55d82f3e1ec3435af54702333659e9f91c
Bug 1483051 - Update to whitenoise 4

* Renames `is_immutable_file` to match changes to the parent class.
* Suppresses the new "missing static files directory" warning when
  running the tests (since it's expected in !production).
* Uses the new `extras_require` `[brotli]` entry to make WhiteNoise's
  dependency more obvious.

Changelog:
http://whitenoise.evans.io/en/stable/changelog.html#v4-0

Closes #3903.

https://github.com/mozilla/treeherder/commit/2eb1cf2d31a7eecd2459c5c763befdab174bc72b
Bug 1483051 - Use WhiteNoise 4's new native index file support

Index files are now natively supported so our custom implementation
can be removed. See:
http://whitenoise.evans.io/en/stable/django.html#index-files-django

https://github.com/mozilla/treeherder/commit/48d0cba0c765a86b847f98239f7442f91e900e02
Bug 1483051 - Only process/output hashed files during collectstatic

By default Django/WhiteNoise outputs not only the hashed version of
static files (eg `app.db8f2edc0c8a.js`) but also the original file
(eg `app.js`), for backwards compatibility in case users hardcode
the original filename in their app.

However Treeherder doesn't do this, so we can skip the original files,
halving the number of files output - and thus halving the time spent
Brotli/gzip compressing them during collectstatic.

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8999784 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3916

George kindly reviewed this on GitHub :-)