Remove BrowserOpenSyncTabs and use gSync.openSyncedTabsPanel() instead

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P5
normal
RESOLVED FIXED
9 months ago
8 months ago

People

(Reporter: ntim, Assigned: arshadkazmi42, Mentored)

Tracking

({good-first-bug})

unspecified
Firefox 63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 months ago
I see absolutely no value having this 1 line helper function.

In browser-menubar.inc, replace BrowserOpenSyncTabs() with gSync.openSyncedTabsPanel()

and in browser.js, remove the BrowserOpenSyncTabs function.
Would you be willing to mentor and make this a good-first-bug Tim?
Flags: needinfo?(ntim.bugs)
Priority: -- → P5
(Reporter)

Updated

8 months ago
Mentor: ntim.bugs
Flags: needinfo?(ntim.bugs)
(Assignee)

Comment 2

8 months ago
Is it open for grab? I am interested to work on it
Flags: needinfo?(ntim.bugs)
(Reporter)

Comment 3

8 months ago
(In reply to Arshad Kazmi from comment #2)
> Is it open for grab? I am interested to work on it


Yes :) Please feel free to open a patch.

Let me know if you have any questions.
Assignee: nobody → arshadkazmi42
Flags: needinfo?(ntim.bugs)
(Assignee)

Comment 5

8 months ago
Added code to Phrabricator.

https://phabricator.services.mozilla.com/D4281

No added any reviewer, whom should I add as reviewer?
Flags: needinfo?(ntim.bugs)
(Reporter)

Comment 6

8 months ago
I added Gijs as reviewer.
Flags: needinfo?(ntim.bugs)
(Assignee)

Comment 7

8 months ago
Thanks. Will wait for his feedback

Comment 8

8 months ago
Comment on attachment 9003976 [details]
Bug 1483073 - Remove BrowserOpenSyncTab() helper function

:Gijs (he/him) has approved the revision.
Attachment #9003976 - Flags: review+
Attachment #9003976 - Attachment description: Bug-1483073: Removed BrowserOpenSyncTab() → Bug 1483073 - Remove BrowserOpenSyncTab() helper function

Comment 9

8 months ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7141688c4eca
Remove BrowserOpenSyncTab() helper function r=Gijs

Comment 10

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7141688c4eca
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.