1483073 - Remove BrowserOpenSyncTabs and use gSync.openSyncedTabsPanel() instead

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P5)

Description

[Tim Nguyen :ntim]

I see absolutely no value having this 1 line helper function.

In browser-menubar.inc, replace BrowserOpenSyncTabs() with gSync.openSyncedTabsPanel()

and in browser.js, remove the BrowserOpenSyncTabs function.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Would you be willing to mentor and make this a good-first-bug Tim?

Comment 2

[Arshad Kazmi [:arshadkazmi42]]

Is it open for grab? I am interested to work on it

Comment 3

[Tim Nguyen :ntim]

(In reply to Arshad Kazmi from comment #2)
> Is it open for grab? I am interested to work on it


Yes :) Please feel free to open a patch.

Let me know if you have any questions.

Comment 4

[Arshad Kazmi [:arshadkazmi42]]

Attachment: Bug 1483073 - Remove BrowserOpenSyncTab() helper function

Comment 5

[Arshad Kazmi [:arshadkazmi42]]

Added code to Phrabricator.

https://phabricator.services.mozilla.com/D4281

No added any reviewer, whom should I add as reviewer?

Comment 6

[Tim Nguyen :ntim]

I added Gijs as reviewer.

Comment 7

[Arshad Kazmi [:arshadkazmi42]]

Thanks. Will wait for his feedback

Comment 8

[:Gijs (he/him)]

Comment on attachment 9003976 [details]
Bug 1483073 - Remove BrowserOpenSyncTab() helper function

:Gijs (he/him) has approved the revision.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7141688c4eca
Remove BrowserOpenSyncTab() helper function r=Gijs

Comment 10

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/7141688c4eca