1483093 - MIPS MacroAssembler::cmp32Set compiling error

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[qiaopengcheng]

compiling the inbound,
./mach configure
./mach build


compiling error as the following,

/home/qiao/work_qiao/open_src/inbound/js/src/jit/mips64/MacroAssembler-mips64-inl.h:483:5: error: no matching function for call to ‘js::jit::MacroAssembler::ma_cmp_set(js::jit::Register&, js::jit::Address&, js::jit::Register&, js::jit::AssemblerMIPSShared::Condition&)’
 0:36.80      ma_cmp_set(dest, lhs, rhs, cond);
 0:36.81      ^~~~~~~~~~

Comment 1

[qiaopengcheng]

Attachment: Fix mips64 compiling error for ma_cmp_set()

Comment 2

[Dragan Mladjenovic]

Comment on attachment 8999797 [details] [diff] [review]
Fix mips64 compiling error for ma_cmp_set()

Review of attachment 8999797 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips64/MacroAssembler-mips64.h
@@ +166,5 @@
>  
>      void ma_cmp_set(Register dst, Register lhs, ImmWord imm, Condition c);
>      void ma_cmp_set(Register dst, Register lhs, ImmPtr imm, Condition c);
> +    void ma_cmp_set(Register dst, Register lhs, Address addr, Condition c) {
> +        MOZ_ASSERT(lhs != ScratchRegister);

I think you should just define something a la https://searchfox.org/mozilla-central/source/js/src/jit/mips64/MacroAssembler-mips64-inl.h#781. SizeDouble load would be wrong for cmp32Set.

Comment 3

[qiaopengcheng]

(In reply to Dragan Mladjenovic from comment #2)
> Comment on attachment 8999797 [details] [diff] [review]
> Fix mips64 compiling error for ma_cmp_set()
> 
> Review of attachment 8999797 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/jit/mips64/MacroAssembler-mips64.h
> @@ +166,5 @@
> >  
> >      void ma_cmp_set(Register dst, Register lhs, ImmWord imm, Condition c);
> >      void ma_cmp_set(Register dst, Register lhs, ImmPtr imm, Condition c);
> > +    void ma_cmp_set(Register dst, Register lhs, Address addr, Condition c) {
> > +        MOZ_ASSERT(lhs != ScratchRegister);
> 
> I think you should just define something a la
> https://searchfox.org/mozilla-central/source/js/src/jit/mips64/
> MacroAssembler-mips64-inl.h#781. SizeDouble load would be wrong for cmp32Set.


Loading the Address on mips64 should be SizeDouble.
Why SizeDouble load would be wrong for cmp32Set ?

Comment 4

[qiaopengcheng]

(In reply to Dragan Mladjenovic from comment #2)
> Comment on attachment 8999797 [details] [diff] [review]
> Fix mips64 compiling error for ma_cmp_set()
> 
> Review of attachment 8999797 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/jit/mips64/MacroAssembler-mips64.h
> @@ +166,5 @@
> >  
> >      void ma_cmp_set(Register dst, Register lhs, ImmWord imm, Condition c);
> >      void ma_cmp_set(Register dst, Register lhs, ImmPtr imm, Condition c);
> > +    void ma_cmp_set(Register dst, Register lhs, Address addr, Condition c) {
> > +        MOZ_ASSERT(lhs != ScratchRegister);
> 
> I think you should just define something a la
> https://searchfox.org/mozilla-central/source/js/src/jit/mips64/
> MacroAssembler-mips64-inl.h#781. SizeDouble load would be wrong for cmp32Set.

Thank you, I'll amend it.

Comment 5

[qiaopengcheng]

Attachment: Fix mips64 compiling error for ma_cmp_set()

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8dd8272a5aea
Fix mips64 compiling error for ma_cmp_set(). r=dragan.mladjenovic

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8dd8272a5aea