Closed Bug 1483093 Opened 3 years ago Closed 3 years ago

MIPS MacroAssembler::cmp32Set compiling error

Categories

(Core :: JavaScript Engine: JIT, enhancement)

63 Branch
Other
Linux
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: qiaopengcheng-hf, Assigned: qiaopengcheng-hf)

Details

Attachments

(1 file, 1 obsolete file)

compiling the inbound,
./mach configure
./mach build


compiling error as the following,

/home/qiao/work_qiao/open_src/inbound/js/src/jit/mips64/MacroAssembler-mips64-inl.h:483:5: error: no matching function for call to ‘js::jit::MacroAssembler::ma_cmp_set(js::jit::Register&, js::jit::Address&, js::jit::Register&, js::jit::AssemblerMIPSShared::Condition&)’
 0:36.80      ma_cmp_set(dest, lhs, rhs, cond);
 0:36.81      ^~~~~~~~~~
Attachment #8999797 - Flags: review?(jdemooij)
Comment on attachment 8999797 [details] [diff] [review]
Fix mips64 compiling error for ma_cmp_set()

Review of attachment 8999797 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips64/MacroAssembler-mips64.h
@@ +166,5 @@
>  
>      void ma_cmp_set(Register dst, Register lhs, ImmWord imm, Condition c);
>      void ma_cmp_set(Register dst, Register lhs, ImmPtr imm, Condition c);
> +    void ma_cmp_set(Register dst, Register lhs, Address addr, Condition c) {
> +        MOZ_ASSERT(lhs != ScratchRegister);

I think you should just define something a la https://searchfox.org/mozilla-central/source/js/src/jit/mips64/MacroAssembler-mips64-inl.h#781. SizeDouble load would be wrong for cmp32Set.
(In reply to Dragan Mladjenovic from comment #2)
> Comment on attachment 8999797 [details] [diff] [review]
> Fix mips64 compiling error for ma_cmp_set()
> 
> Review of attachment 8999797 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/jit/mips64/MacroAssembler-mips64.h
> @@ +166,5 @@
> >  
> >      void ma_cmp_set(Register dst, Register lhs, ImmWord imm, Condition c);
> >      void ma_cmp_set(Register dst, Register lhs, ImmPtr imm, Condition c);
> > +    void ma_cmp_set(Register dst, Register lhs, Address addr, Condition c) {
> > +        MOZ_ASSERT(lhs != ScratchRegister);
> 
> I think you should just define something a la
> https://searchfox.org/mozilla-central/source/js/src/jit/mips64/
> MacroAssembler-mips64-inl.h#781. SizeDouble load would be wrong for cmp32Set.


Loading the Address on mips64 should be SizeDouble.
Why SizeDouble load would be wrong for cmp32Set ?
(In reply to Dragan Mladjenovic from comment #2)
> Comment on attachment 8999797 [details] [diff] [review]
> Fix mips64 compiling error for ma_cmp_set()
> 
> Review of attachment 8999797 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/jit/mips64/MacroAssembler-mips64.h
> @@ +166,5 @@
> >  
> >      void ma_cmp_set(Register dst, Register lhs, ImmWord imm, Condition c);
> >      void ma_cmp_set(Register dst, Register lhs, ImmPtr imm, Condition c);
> > +    void ma_cmp_set(Register dst, Register lhs, Address addr, Condition c) {
> > +        MOZ_ASSERT(lhs != ScratchRegister);
> 
> I think you should just define something a la
> https://searchfox.org/mozilla-central/source/js/src/jit/mips64/
> MacroAssembler-mips64-inl.h#781. SizeDouble load would be wrong for cmp32Set.

Thank you, I'll amend it.
Attachment #8999797 - Attachment is obsolete: true
Attachment #8999797 - Flags: review?(jdemooij)
Attachment #8999862 - Flags: review?(dragan.mladjenovic)
Attachment #8999862 - Flags: review+
Attachment #8999862 - Flags: review?(dragan.mladjenovic)
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8dd8272a5aea
Fix mips64 compiling error for ma_cmp_set(). r=dragan.mladjenovic
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8dd8272a5aea
Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Assignee: nobody → qiaopengcheng-hf
You need to log in before you can comment on or make changes to this bug.