1483135 - The @google, @amazon ... tiles are not tabable with the keyboard, only their context menu buttons are.

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Marco Zehe (:MarcoZ)]

This is because these are html:a elements with an onclick handler, but no href attribute. Accessibility sees them as links fine, but DOM doesn't consider them focusable because of the missing href.

Easy fix: Slap an tabindex="0" attribute onto them.

Priority suggestion: This should be done for current release as to give keyboard-only users a full accessible experience for these.

Comment 1

[Ed Lee :Mardak]

tabindex=0 is insufficient to trigger the onclick here, but it does allow it to be tabbed to.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4337

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/c9ab6cf948316f0d9a62349d21721765fec940db
Fix Bug 1483135 - Search shortcuts are not tabbable

https://github.com/mozilla/activity-stream/commit/b4046f78aafb66af96f183353696a7c37af6529e
Merge pull request #4337 from sarracini/bug_1483135

Fix Bug 1483135 - Search shortcuts are not tabbable

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/13cca9e3e12d

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e752b54a20f425449e1f00bf3adefa903f8051a

Comment 6

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible in the latest Nightly (63.0a1, Build ID 20180816100035) on Windows 10, Mac 10.13 and Arch Linux x64.

Comment 7

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using an older version of Firefox (2018-08-14) on Windows 10.
I retested everything using beta 62.0b18 on Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.13. The bug is not reproducing anymore.