1483148 - javascript: bookmarklets no longer work after disallowInheritPrincipal bug 1466801

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Chris Peterson [:cpeterson]]

[Tracking Requested - why for this release]:

This is a functionality regression in 63 Nightly. I bisected this regression to the following pushlog, which points to disallowInheritPrincipal bug 1466801:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9112406a54a2d3806112111620f25267203a992e&tochange=b5e9fdddf12e598962d6282a4b053aa66b7aabda

STR:
1. Install a javascript: bookmarklet, such as this Hacker News bookmarklet to submit links to Hacker News, by dragging it to your bookmarks toolbar:
https://news.ycombinator.com/bookmarklet.html

2. Click the Hacker News bookmarklet.

EXPECTED RESULT:
Hacker News' link submission page should be opened.

ACTUAL RESULT:
Nothing happens.

Comment 1

[Chris Peterson [:cpeterson]]

This bug is a regression from disallowInheritPrincipal bug 1466801.

Comment 2

[Jonathan Kingston [:jkt] he/him]

Attachment: Bug 1483148 - Add allowInheritPrincipal to current tab bookmarklets.

Comment 4

[Jan Moesen]

FWIW, they still work when you execute them using the custom keyword, if any. However, if you try to execute them using the keyword and pressing Alt+Enter to open them in a new tab, they don't work. Open the new tab first, and then execute it using the keyword as a temporary workaround.

Comment 5

[Mark Banner (:standard8)]

(In reply to Jan Moesen from comment #4)
> FWIW, they still work when you execute them using the custom keyword, if
> any. However, if you try to execute them using the keyword and pressing
> Alt+Enter to open them in a new tab, they don't work. Open the new tab
> first, and then execute it using the keyword as a temporary workaround.

Please file that as a separate bug under the address bar. Keywords work differently to bookmarks on the toolbar.

Comment 6

[Mark Banner (:standard8)]

(In reply to Jonathan Kingston [:jkt] (Away until 20th Aug) from comment #2)
> Created attachment 8999879 [details]
> Bug 1483148 - Add allowInheritPrincipal to current tab bookmarklets.

Why only the current tab? As far as I can tell, the use case for middle-clicking a javascript bookmarklet on the toolbar is still broken.

Comment 7

[Jan Moesen]

Filed bug 1484741.

Comment 8

[:Gijs (he/him)]

Comment on attachment 8999879 [details]
Bug 1483148 - Add allowInheritPrincipal to current tab bookmarklets.

:Gijs (he/him) has approved the revision.

Comment 9

[Jonathan Kingston [:jkt] he/him]

> Why only the current tab? As far as I can tell, the use case for middle-clicking a javascript bookmarklet on the toolbar is still broken.

From my testing it only is needed when it is applying to the current document rather than creating it's own document. However I will double check tomorrow. Also perhaps we can just use the document principal in this case instead.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d88272387d1
Add allowInheritPrincipal to current tab bookmarklets. r=Gijs

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8d88272387d1