Closed
Bug 1483252
Opened 4 years ago
Closed 4 years ago
Replace 0px with 0 throughout menu.css
Categories
(Toolkit :: Themes, enhancement, P3)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: dao, Assigned: bharatraghunthan9767, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
0 doesn't need a unit in CSS since 0px is the same as 0em for instance. So let's remove the "px": https://searchfox.org/mozilla-central/search?q=+0px&case=true&path=menu.css
Hi, I would like to work on this one. I do not yet have the Firefox source code, so I would probably need to start off with that.
Reporter | ||
Comment 2•4 years ago
|
||
(In reply to Bojan from comment #1) > Hi, I would like to work on this one. I do not yet have the Firefox source > code, so I would probably need to start off with that. You can find instructions here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code/Mercurial
OK, I followed the guide and installed Mercurial, then I pulled the Firefox source code from https://hg.mozilla.org/mozilla-central/, however, since I am coming from Git, I am now not sure how to proceed next. This would be my first contribution to Firefox's source code :)
Comment 4•4 years ago
|
||
(In reply to Bojan from comment #3) > OK, I followed the guide and installed Mercurial, then I pulled the Firefox > source code from https://hg.mozilla.org/mozilla-central/, however, since I > am coming from Git, I am now not sure how to proceed next. This would be my > first contribution to Firefox's source code :) This might be helpful: https://gist.github.com/cortesben/016cd401faae5a8dae59
Thanks Tim and Dao for the great help! I was able to make changes, and configured Mercurial through mach, however, when I commited and pushed the changes to a review repo using ```hg push review```, I ended up getting the message ```MozReview is no longer accepting new review requests``` However, my changes did end up here: https://reviewboard-hg.mozilla.org/gecko/rev/4cf83a05b94b Does that look good, or did I miss something?
Flags: needinfo?(dao+bmo)
Reporter | ||
Comment 6•4 years ago
|
||
(In reply to Bojan from comment #5) > Thanks Tim and Dao for the great help! I was able to make changes, and > configured Mercurial through mach, however, when I commited and pushed the > changes to a review repo using ```hg push review```, I ended up getting the > message ```MozReview is no longer accepting new review requests``` > > However, my changes did end up here: > https://reviewboard-hg.mozilla.org/gecko/rev/4cf83a05b94b > > Does that look good, or did I miss something? Sorry for the confusion. We're in the process of transitioning away from ReviewBoard / MozReview. Your patch looks good except that your mozilla-central copy is now slightly out of date because bug 1482609 landed in the meantime: applying https://reviewboard-hg.mozilla.org/gecko/raw-rev/4cf83a05b94b patching file toolkit/themes/linux/global/menu.css Hunk #2 FAILED at 90
Flags: needinfo?(dao+bmo)
Assignee | ||
Comment 7•4 years ago
|
||
Can you please review the patch I made at https://phabricator.services.mozilla.com/D3689 And will patches show up as an attachment here after migration out of MozReview is finished?
Flags: needinfo?(dao+bmo)
Assignee | ||
Comment 8•4 years ago
|
||
MozReview-Commit-ID: DiHVfBuSH7V
Reporter | ||
Comment 9•4 years ago
|
||
Comment on attachment 9002212 [details] Bug 1483252 - Replace 0px with 0 throughout menu.css Dão Gottwald [::dao] has approved the revision.
Attachment #9002212 -
Flags: review+
Reporter | ||
Updated•4 years ago
|
Assignee: nobody → bharatraghunthan9767
Flags: needinfo?(dao+bmo)
Comment 10•4 years ago
|
||
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/060ff053ae27 Replace 0px with 0 throughout menu.css r=dao
Comment 11•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/060ff053ae27
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•