1483269 - js::jit::AbortReason and js::gc::AbortReason do no play nice in very-unified builds

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P5)

Description

[Jon Coppeard (:jonco)]

We could rename gc::AbortReason to GCAbortReason as I think this is used less frequently.

Comment 1

[Shivam Singhal [ :championshuttler ]]

Hi @All, I would like to work on it , can any one help me how to get started with it please :)


Thanks

Comment 2

[Ted Campbell [:tcampbell]]

(In reply to Shivam Singhal [ :championshuttler ] from comment #1)
> Hi @All, I would like to work on it , can any one help me how to get started
> with it please :)

Great!

Start with reading: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction

This has the general overview of the process and a lot of helpful links. The SpiderMonkey specific build instructions are: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Build_Documentation

This query will show the primary places you'll need to fix for this change. https://searchfox.org/mozilla-central/search?q=symbol:T_js%3A%3Agc%3A%3AAbortReason&redirect=false

If you have further questions, post in this bug or try one of the IRC channels (#introduction or #jsapi).

Comment 3

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1483269 - Rename gc::AbortReason to GCAbortReason

Rename gc::AbortReason to GCAbortReason

Comment 4

[Barun]

Hi, Is this issue available to work on?

From what I understand I need to rename all the gc::AbortReason to GCAbortReason.

Comment 5

[Ted Campbell [:tcampbell]]

Yes, feel free to take a look look at this.

You'll need to make sure you can build spidermonkey and there are instructions here: https://firefox-source-docs.mozilla.org/js/build.html

You will need to be careful of other uses of AbortReason that refer to a different type than gc::AbortReason. Most the cases you would likely change are found here https://searchfox.org/mozilla-central/search?q=symbol:T_js%3A%3Agc%3A%3AAbortReason&redirect=false

Comment 6

[Barun]

(In reply to Ted Campbell [:tcampbell] from comment #5)

You'll need to make sure you can build spidermonkey and there are instructions here: https://firefox-source-docs.mozilla.org/js/build.html

Yes I have built it and it works already.

You will need to be careful of other uses of AbortReason that refer to a different type than gc::AbortReason. Most the cases you would likely change are found here https://searchfox.org/mozilla-central/search?q=symbol:T_js%3A%3Agc%3A%3AAbortReason&redirect=false

Thanks. I will get started then.

Comment 7

[Barun]

Attachment: Bug 1483269 - Rename gc::AbortReason to GCAbortReason; r?tcampbell

Comment 8

[Barun]

Attachment: Bug 1483269 - Change definition of gc::AbortReason to GCAbortReason

Depends on D86431

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34a0cc6dd653
Rename gc::AbortReason to GCAbortReason; r=tcampbell

Comment 10

[Barun]

Thanks tcampbell for guiding me through the bug. Can you link me another bug on which I can work on?

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/34a0cc6dd653