js::jit::AbortReason and js::gc::AbortReason do no play nice in very-unified builds
Categories
(Core :: JavaScript: GC, enhancement, P5)
Tracking
()
Tracking | Status | |
---|---|---|
firefox81 | --- | fixed |
People
(Reporter: jonco, Assigned: barun1024)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file, 2 obsolete files)
We could rename gc::AbortReason to GCAbortReason as I think this is used less frequently.
Comment 1•5 years ago
|
||
Hi @All, I would like to work on it , can any one help me how to get started with it please :) Thanks
Comment 2•5 years ago
|
||
(In reply to Shivam Singhal [ :championshuttler ] from comment #1) > Hi @All, I would like to work on it , can any one help me how to get started > with it please :) Great! Start with reading: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction This has the general overview of the process and a lot of helpful links. The SpiderMonkey specific build instructions are: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Build_Documentation This query will show the primary places you'll need to fix for this change. https://searchfox.org/mozilla-central/search?q=symbol:T_js%3A%3Agc%3A%3AAbortReason&redirect=false If you have further questions, post in this bug or try one of the IRC channels (#introduction or #jsapi).
Comment 3•5 years ago
|
||
Rename gc::AbortReason to GCAbortReason
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Hi, Is this issue available to work on?
From what I understand I need to rename all the gc::AbortReason
to GCAbortReason
.
Comment 5•4 years ago
|
||
Yes, feel free to take a look look at this.
You'll need to make sure you can build spidermonkey and there are instructions here: https://firefox-source-docs.mozilla.org/js/build.html
You will need to be careful of other uses of AbortReason
that refer to a different type than gc::AbortReason
. Most the cases you would likely change are found here https://searchfox.org/mozilla-central/search?q=symbol:T_js%3A%3Agc%3A%3AAbortReason&redirect=false
(In reply to Ted Campbell [:tcampbell] from comment #5)
You'll need to make sure you can build spidermonkey and there are instructions here: https://firefox-source-docs.mozilla.org/js/build.html
Yes I have built it and it works already.
You will need to be careful of other uses of
AbortReason
that refer to a different type thangc::AbortReason
. Most the cases you would likely change are found here https://searchfox.org/mozilla-central/search?q=symbol:T_js%3A%3Agc%3A%3AAbortReason&redirect=false
Thanks. I will get started then.
Updated•4 years ago
|
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/34a0cc6dd653 Rename gc::AbortReason to GCAbortReason; r=tcampbell
Assignee | ||
Comment 10•4 years ago
|
||
Thanks tcampbell for guiding me through the bug. Can you link me another bug on which I can work on?
Comment 11•4 years ago
|
||
bugherder |
Description
•