1483301 - Raise the New Relic Python agent's shutdown_timeout

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Infrastructure, enhancement, P1)

Description

[Ed Morley [:emorley]]

The New Relic agent's `shutdown_timeout` setting defaults to 2.5 seconds, for compatibility with web servers that have a low default timeout threshold:
https://docs.newrelic.com/docs/agents/python-agent/configuration/python-agent-configuration#shutdown-timeout

However gunicorn's `graceful_timeout` defaults to 30 seconds, so we're fine to raise the New Relic shutdown timeout a bit:
http://docs.gunicorn.org/en/stable/settings.html#graceful-timeout

This will reduce the chance that the very last web or celery transaction doesn't get reported to New Relic, eg when Heroku performs its daily restart.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3922

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2418a694a0642c2250b85ca33116bbdf58ef569e
Bug 1483301 - Raise the New Relic Python agent's shutdown_timeout (#3922)

So that the agent has longer to upload the final submission when
Heroku restarts gunicorn (eg daily restarts or deploys).

See:
https://docs.newrelic.com/docs/agents/python-agent/configuration/python-agent-configuration#shutdown-timeout