1483408 - Player is not focused even with bug 1474574

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect, P2)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Spin the failed QA verify to another bug.

This is a bit tricky to reproduce, hopefully I can verify the failure in a test:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e9bf51499c8fb7c0d8bd1016ac985584db6a9b3

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1483408 - Set focus to the video element when the media document loads r=Gijs

For some reason we might miss the initial focus event. This ensures the video
element is focused when the document loads.

Comment 2

[:Gijs (he/him)]

Comment on attachment 9001395 [details]
Bug 1483408 - Set focus to the video element when the media document loads r=Gijs

:Gijs (he/him) has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59c5a173a09d
Set focus to the video element when the media document loads r=Gijs

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/59c5a173a09d

Comment 5

[:Gijs (he/him)]

Comment on attachment 9001395 [details]
Bug 1483408 - Set focus to the video element when the media document loads r=Gijs

Approval Request Comment (copied and modified from bug 1474574)
[Feature/Bug causing the regression]: regression of bug 1444489
[User impact if declined]: The user will not always be able to use keyboard to control media documents.
[Is this code covered by automated tests?]: This patch adds some test coverage.
[Has the fix been verified in Nightly?]: Not yet.
[Needs manual test from QE? If yes, steps to reproduce]: See comment 0, bug 1474574 comment 17 and later.
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: no
[Why is the change risky/not risky?]: minor behavior fix, unlikely to break other things.
[String changes made/needed]: no.

Comment 6

[Gyula Palko[:gpalko]]

Verified, that the issue is no longer reproducible on Nightly 63.0a1(20180820222055), the media player is focused after opening media files.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9001395 [details]
Bug 1483408 - Set focus to the video element when the media document loads r=Gijs

Follow-up fix to bug 1474574. Verified by QA on Nightly. Approved for 62.0b20.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bc6e295b9a0b

Comment 9

[Gabi Cheta [:Gabi] Desktop QA]

I reproduced the initial issue on Firefox 61.0.2.
Verified fixed on Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.12.6 using the 62.0b20 taskcluster build from 2018-08-23.