1483445 - String change to reflect Firefox feature name change from tracking protection to content blocking in 63

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P3)

Description

[mheubusch]

Hello - for the string in line 43 here: https://hg.mozilla.org/l10n/gecko-strings/file/default/netwerk/necko.properties#l43

Please change 

from 
The resource at “%1$S” was blocked because tracking protection is enabled. 

to 
The resource at “%1$S” was blocked because content blocking is enabled.

I'm requesting this change because we are using the new name "content blocking" to encompass tracking protection and other blocking features beginning in 63.

Comment 1

[:Harald Kirschner :digitarald]

Moving to Necko, as this is where the string is defined and the variable used. Console is just showing it.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1483445 - Change string from tracking protection to content blocking r=dragana!

Comment 3

[Dragana Damjanovic [:dragana]]

Comment on attachment 9001388 [details]
Bug 1483445 - Change string from tracking protection to content blocking r=dragana!

Dragana Damjanovic [:dragana] has approved the revision.

Comment 4

[Tanvi Vyas[:tanvi]]

I think developers will want more details - is this due to FastBlock or Tracking Protection?  So something like:

The resource at “%1$S” was blocked because Trackers are blocked in Content Blocking.

Michelle?

Comment 5

[:Harald Kirschner :digitarald]

So far Francois told me that any meta/category information isn't exposed yet; which I would love to display for additional context for bug 1157817.

Which kind of meta information would the backend provide on blocked resources, Tanvi?

Comment 6

[Tanvi Vyas[:tanvi]]

Francois - we can't differentiate between something blocked from FastBlock and something blocked from Tracking Protection?  
* If we can't differentiate, then the current string is fine and we should file a but to change this to be more specific and mark it dependent on the platform bug.  
* If we can differentiate, we should update the string to be more specific.

Comment 7

[François Marier [:francois]]

(In reply to Tanvi Vyas[:tanvi] from comment #6)
> Francois - we can't differentiate between something blocked from FastBlock
> and something blocked from Tracking Protection? 

I believe that's how it is now, yes. See bug 1481252.

Comment 8

[mheubusch]

Tanvi - for now, IIUC Francois's comment, the string should remain The resource at “%1$S” was blocked because content blocking is enabled.

Do you want to NI me when the new bug is created and I can write new strings that differentiate the scenarios?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffb2036e3283
Change string from tracking protection to content blocking r=dragana!

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ffb2036e3283