String change to reflect Firefox feature name change from tracking protection to content blocking in 63

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P3
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: mheubusch, Assigned: valentin, NeedInfo)

Tracking

63 Branch
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 attachment)

Reporter

Description

9 months ago
Hello - for the string in line 43 here: https://hg.mozilla.org/l10n/gecko-strings/file/default/netwerk/necko.properties#l43

Please change 

from 
The resource at “%1$S” was blocked because tracking protection is enabled. 

to 
The resource at “%1$S” was blocked because content blocking is enabled.

I'm requesting this change because we are using the new name "content blocking" to encompass tracking protection and other blocking features beginning in 63.
Moving to Necko, as this is where the string is defined and the variable used. Console is just showing it.
Component: Console → Networking
Product: DevTools → Core
Target Milestone: --- → mozilla63
Version: unspecified → 63 Branch
Assignee

Updated

9 months ago
Assignee: nobody → valentin.gosu
Priority: -- → P3
Whiteboard: [necko-triaged]
Comment on attachment 9001388 [details]
Bug 1483445 - Change string from tracking protection to content blocking r=dragana!

Dragana Damjanovic [:dragana] has approved the revision.
Attachment #9001388 - Flags: review+

Comment 4

9 months ago
I think developers will want more details - is this due to FastBlock or Tracking Protection?  So something like:

The resource at “%1$S” was blocked because Trackers are blocked in Content Blocking.

Michelle?
Flags: needinfo?(mheubusch)
So far Francois told me that any meta/category information isn't exposed yet; which I would love to display for additional context for bug 1157817.

Which kind of meta information would the backend provide on blocked resources, Tanvi?
Flags: needinfo?(tanvi)

Comment 6

9 months ago
Francois - we can't differentiate between something blocked from FastBlock and something blocked from Tracking Protection?  
* If we can't differentiate, then the current string is fine and we should file a but to change this to be more specific and mark it dependent on the platform bug.  
* If we can differentiate, we should update the string to be more specific.
Flags: needinfo?(tanvi) → needinfo?(francois)
(In reply to Tanvi Vyas[:tanvi] from comment #6)
> Francois - we can't differentiate between something blocked from FastBlock
> and something blocked from Tracking Protection? 

I believe that's how it is now, yes. See bug 1481252.
Flags: needinfo?(francois)
Reporter

Comment 8

9 months ago
Tanvi - for now, IIUC Francois's comment, the string should remain The resource at “%1$S” was blocked because content blocking is enabled.

Do you want to NI me when the new bug is created and I can write new strings that differentiate the scenarios?

Comment 9

9 months ago
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ffb2036e3283
Change string from tracking protection to content blocking r=dragana!

Comment 10

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ffb2036e3283
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED

Updated

9 months ago
Blocks: 1481233
You need to log in before you can comment on or make changes to this bug.