1483569 - mqext breaks with 4.6.2 (unexpected keyword argument 'fp')

Status: RESOLVED DUPLICATE of bug 1483722

(Developer Services :: Mercurial: mozext, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

$ hg qshow
** unknown exception encountered, please report by visiting
** https://mercurial-scm.org/wiki/BugTracker
** Python 2.7.15 (default, May  9 2018, 11:32:33) [GCC 7.3.1 20180130 (Red Hat 7.3.1-2)]
** Mercurial Distributed SCM (version 4.6.2)
** Extensions loaded: strip, mq, bzexport, rebase, relink, transplant, graphlog, histedit, record, mqext, qbackout, reviewboard, qimportbz, blackbox, evolve, fsmonitor
Traceback (most recent call last):
  File "/usr/local/bin/hg", line 41, in <module>
    dispatch.run()
  File "/usr/local/lib64/python2.7/site-packages/mercurial/dispatch.py", line 90, in run
    status = (dispatch(req) or 0)
  File "/usr/local/lib64/python2.7/site-packages/mercurial/dispatch.py", line 210, in dispatch
    ret = _runcatch(req)
  File "/usr/local/lib64/python2.7/site-packages/mercurial/dispatch.py", line 351, in _runcatch
    return _callcatch(ui, _runcatchfunc)
  File "/usr/local/lib64/python2.7/site-packages/mercurial/dispatch.py", line 359, in _callcatch
    return scmutil.callcatch(ui, func)
  File "/usr/local/lib64/python2.7/site-packages/mercurial/scmutil.py", line 160, in callcatch
    return func()
  File "/usr/local/lib64/python2.7/site-packages/mercurial/dispatch.py", line 341, in _runcatchfunc
    return _dispatch(req)
  File "/usr/local/lib64/python2.7/site-packages/mercurial/dispatch.py", line 971, in _dispatch
    cmdpats, cmdoptions)
  File "/usr/local/lib64/python2.7/site-packages/mercurial/dispatch.py", line 727, in runcommand
    ret = _runcommand(ui, options, cmd, d)
  File "/usr/local/lib64/python2.7/site-packages/mercurial/dispatch.py", line 979, in _runcommand
    return cmdfunc()
  File "/usr/local/lib64/python2.7/site-packages/mercurial/dispatch.py", line 968, in <lambda>
    d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
  File "/usr/local/lib64/python2.7/site-packages/mercurial/util.py", line 1553, in check
    return func(*args, **kwargs)
  File "/usr/local/lib64/python2.7/site-packages/mercurial/util.py", line 1553, in check
    return func(*args, **kwargs)
  File "/usr/local/lib64/python2.7/site-packages/hgext/mq.py", line 3599, in mqcommand
    return orig(ui, repo, *args, **kwargs)
  File "/usr/local/lib64/python2.7/site-packages/mercurial/util.py", line 1553, in check
    return func(*args, **kwargs)
  File "/home/jesup/.mozbuild/version-control-tools/hgext/mqext/__init__.py", line 204, in qshow
    cmdutil.export(repo, repo.revs(patchspec), fp=ui)
TypeError: export() got an unexpected keyword argument 'fp'


$ hg --version
Mercurial Distributed SCM (version 4.6.2)
(see https://mercurial-scm.org for more information)

Copyright (C) 2005-2018 Matt Mackall and others
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Enabled extensions:

  strip        internal  
  mq           internal  
  bzexport     external  
  rebase       internal  
  relink       internal  
  transplant   internal  
  graphlog     internal  
  histedit     internal  
  record       internal  
  mqext        external  
  qbackout     external  
  reviewboard  external  
  qimportbz    external  
  push-to-try  external  
  blackbox     internal  
  evolve       external  8.1.1.dev
  fsmonitor    internal

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: mqext: use `cmdutil.exportfile` on Mercurial 4.6+ (Bug 1483569) r?gps

The `fp` argument of `cmdutil.export` has been deprecated. In
Mercurial 4.6+, `cmdutil.exportfile` should be used instead.

Comment 2

[Connor Sheehan [:sheehan]]

Duplicate of bug 1483722. One of the patches that landed for that bug will fix the stack trace reported in this bug, please raise any other issues over there.