Check if code coverage file exists on the emulator before running adb pull

RESOLVED FIXED in Firefox 63

Status

()

enhancement
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: gabriel-v, Assigned: gabriel-v)

Tracking

(Blocks 1 bug)

unspecified
Firefox 63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

9 months ago
If Gecko hangs while running tests with code coverage or otherwise fails to create the coverage.ec file on the emulator, the `adb pull` call from `runjunit.py` will throw a ADBProcessError, which causes the task to retry.

We should stop those retries from happening, mostly because of bug 1481856.
Assignee

Comment 1

9 months ago
Catch the exception if adb pull fails on code coverage file, to avoid task retry.
Comment on attachment 9001588 [details]
Bug 1483586 - Avoid task retry if adb pull fails on code coverage file.

Geoff Brown [:gbrown] (pto Aug 20-Aug 24) has approved the revision.
Attachment #9001588 - Flags: review+
Assignee

Updated

9 months ago
Keywords: checkin-needed

Comment 3

9 months ago
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b26c8a754e40
Avoid task retry if adb pull fails on code coverage file. r=gbrown
Keywords: checkin-needed

Comment 4

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b26c8a754e40
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.