Closed Bug 1483586 Opened 2 years ago Closed 2 years ago

Check if code coverage file exists on the emulator before running adb pull

Categories

(Firefox for Android :: Testing, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: gabriel-v, Assigned: gabriel-v)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

If Gecko hangs while running tests with code coverage or otherwise fails to create the coverage.ec file on the emulator, the `adb pull` call from `runjunit.py` will throw a ADBProcessError, which causes the task to retry.

We should stop those retries from happening, mostly because of bug 1481856.
Catch the exception if adb pull fails on code coverage file, to avoid task retry.
Comment on attachment 9001588 [details]
Bug 1483586 - Avoid task retry if adb pull fails on code coverage file.

Geoff Brown [:gbrown] (pto Aug 20-Aug 24) has approved the revision.
Attachment #9001588 - Flags: review+
Keywords: checkin-needed
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b26c8a754e40
Avoid task retry if adb pull fails on code coverage file. r=gbrown
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b26c8a754e40
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.