1483595 - add NodeJS to the default build

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement, P1)

Description

[Dan Mosedale (:dmose, :dmosedale)]

Set --enable-default in the build.

Creating a fresh bug for the patch that will be landed so that if people need to track down issues or bisect, they don't have to wade through all of the now-irrelevant stuff in bug 1464123.

The best summary of what's going on here, and what to do if this causes problems for you is:

https://docs.google.com/document/d/1SsFx5FDlY5JsM421opRM8nuWaTLMiqNZajrhsIL8jow/edit

Comment 1

[Dan Mosedale (:dmose, :dmosedale)]

And if that link should someday stop working, https://groups.google.com/d/msg/mozilla.dev.builds/RaeGCwcPYg8/BylibHAxCwAJ will likely still be valid.

Comment 2

[Dan Mosedale (:dmose, :dmosedale)]

Attachment: turn on NodeJS by default in the builds

MozReview-Commit-ID: AlKuz8BTKM3

Comment 3

[Dan Mosedale (:dmose, :dmosedale)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=764524fa8130b41e32b5ab53cd330c1ce6e43174

Comment 4

[Dan Mosedale (:dmose, :dmosedale)]

Attachment: turn on NodeJS by default in the builds, v2

Same patch with an output message typo fixed.

MozReview-Commit-ID: AlKuz8BTKM3

Comment 5

[Dan Mosedale (:dmose, :dmosedale)]

OK, based on the try-server output, I have a=ryanVM over IRC in #build to merge directly to mozilla-central.  The plan is to do that first-thing Thursday morning Pacific time, so that I'll be around to help out if any issues occur.

I'll be sure to notify #sheriffs before doing the actual push.

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 9001337 [details] [diff] [review]
turn on NodeJS by default in the builds, v2

Review of attachment 9001337 [details] [diff] [review]:
-----------------------------------------------------------------

This seems reasonable. We may want to add some imply_option() in here so various build configurations that don't need Node don't require it. But we can do that as a follow-up. I think it is best to paint with a wide brush at this point in time so everyone deals with the transition now and we're not finding (as many) people with issues weeks or months down the line.

::: build/moz.configure/node.configure
@@ +66,5 @@
> +
> +If you believe this is a bug, <https://mzl.la/2vLbXAv> is a good way
> +to file.  Executing `mach bootstrap --no-system changes` should
> +install a compatible version in ~/.mozbuild on most platforms.
> +More details: <http://bit.ly/2BbyD1E>

Please switch this to a https:// URL. I'd just drop the Google link instead of going through a shortener. But meh.

Comment 7

[Dan Mosedale (:dmose, :dmosedale)]

Attachment: turn on NodeJS by default in the builds, v3

http link switched to https

MozReview-Commit-ID: AlKuz8BTKM3

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/cfbaf72d15f0
turn on NodeJS by default in the builds, r=gps, a=RyanVM

Comment 9

[Jonathan Kew (:jfkthame)]

Comment on attachment 9001679 [details] [diff] [review]
turn on NodeJS by default in the builds, v3

Review of attachment 9001679 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/moz.configure/node.configure
@@ +64,5 @@
>  
> +    MAYBE_FILE_A_BUG = '''
> +
> +If you believe this is a bug, <https://mzl.la/2vLbXAv> is a good way
> +to file.  Executing `mach bootstrap --no-system changes` should

Shouldn't this be "--no-system-changes" (as a single arg)?

Comment 10

[Jonathan Kew (:jfkthame)]

ni?:dmose for the apparent typo (see comment 9) in the message.

Comment 11

[Dan Mosedale (:dmose, :dmosedale)]

Good catch, Jonathan!  I just filed Bug 1484282, and will have a patch there shortly.