1483651 - `mach vendor python` should dereference symlinks from vendored packages

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[(not currently active) Ted Mielczarek]

In bug 1461992 I used `mach vendor python` to update the version of our vendored copy of `voluptuous`, which wound up updating the vendored copy of `funcsigs` as well. This worked, but I couldn't push the patch because the `funcsigs` package included a symlink, which our hg server rejects:
remote: ****************************** ERROR *******************************
remote: 6cc7ca34fe90 adds or modifies the following symlinks:
remote: 
remote:   third_party/python/funcsigs/docs/index.rst
remote: 
remote: Symlinks aren't allowed in this repo. Convert these paths to regular
remote: files and try your push again.
remote: ********************************************************************

We should make sure that `mach vendor python` avoids this, even if it's uncommon.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: bug 1483651 - Dereference symlinks inside vendored Python packages. r=gps

At least one Python package that got vendored via `mach vendor python`
contains a symlink, which hg.mozilla.org rejects. This change makes it so
symlinks get replaced with the contents of the file they point to.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 9003557 [details]
bug 1483651 - Dereference symlinks inside vendored Python packages. r=gps

Gregory Szorc [:gps] has approved the revision.

Comment 4

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f8cad00dc2e9a2a7b2021d676922b433f2255c7
bug 1483651 - Dereference symlinks inside vendored Python packages. r=gps

Comment 5

[Ryan VanderMeulen [:RyanVM]]

This had to be backed out due to merge conflicts with bug 1490253. Feel free to rebase and re-land whenever.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5c1a7734493
Dereference symlinks inside vendored Python packages. r=gps

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/f5c1a7734493