Closed Bug 1483653 Opened 2 years ago Closed 2 years ago

Sites filtered out by improvesearch.noDefaultSearchTile are replaced by default sites

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 63
Iteration:
63.4 - Aug 20
Tracking Status
firefox62 --- verified
firefox63 --- verified

People

(Reporter: k88hudson, Assigned: k88hudson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Since sites are filtered out from a pre-sliced list, we don't have enough overflow to replace them; we need to either send more overflow or move this logic to the NewTabUtils
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/636c2fdec72fa465ef94eb718e92992da9379264
Fix Bug 1483653 - Sites filtered out by improvesearch.noDefaultSearchTile are replaced by default sites (#4349)
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Blocks: 1483671
Blocks: 1482398
STR (for QA):

1.In order to set up the test, set browser.newtabpage.activity-stream.improvesearch.noDefaultSearchTile to false and browser.newtabpage.activity-stream.topSitesRows to 2.
2. Open enough individual sites such that you have exactly 10 organic top sites including search.yahoo.com and google.com.  For example:
  1 example.com
  2 foo.com
  3 reddit.com
  4 search.yahoo.com
  5 google.com
  6 nytimes.com
  7 washingtonpost.com
  8 slack.com
  9 cbc.ca
  10 github.com
2. Set browser.newtabpage.activity-stream.improvesearch.noDefaultSearchTile to true and browser.newtabpage.activity-stream.topSitesRows to 1. Restart the browser. search.yahoo and google.com should no longer show up.

Expected: The last two top sites should be organic top sites (in the given example, cbc.ca and github.com)

Actual (before this patch landed): The last two top sites are default top sites, not organic
I managed to reproduce the issue using an older version of Nightly (2018-08-12) on Windows 10 x64. I used the steps from comment 5. 
I retested everything using beta 62.0b19 and latest Nightly 63.0a1 on Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.12. The bug is not reproducing anymore.
Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.