Closed Bug 1483664 Opened 7 years ago Closed 7 years ago

Use lazy actor infrastructure for LightweightThemeChildHelper

Categories

(WebExtensions :: Themes, enhancement)

Product:
WebExtensions
Component:
Themes
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1483664: Part 1 - Use lazy actor infrastructure for LightweightThemeChild. r=ntim
46 bytes, text/x-phabricator-request
ntim
: review+
Details | Review
Bug 1483664: Part 0 - Dispatch pagehide/pageshow to all system group listeners on frameloader swap. r?smaug,mconley
46 bytes, text/x-phabricator-request
smaug
: review+
mconley
: review+
Details | Review
No description provided.
Attachment #9001369 - Flags: review?(ntim.bugs)
Having to add pagehide/pageshow listeners to the chrome event target is a serious inconvience for the use cases of this bug. Dispatching to system group listeners has approximately the same effect as the old code, but is much easier for window-bound code to handle.
Attachment #9001369 - Attachment description: Bug 1483664: Use lazy actor infrastructure for LightweightThemeChild. r=ntim → Bug 1483664: Part 1 - Use lazy actor infrastructure for LightweightThemeChild. r=ntim
Comment on attachment 9001369 [details] Bug 1483664: Part 1 - Use lazy actor infrastructure for LightweightThemeChild. r=ntim Tim Nguyen :ntim has approved the revision.
Attachment #9001369 - Flags: review+
Comment on attachment 9001369 [details] Bug 1483664: Part 1 - Use lazy actor infrastructure for LightweightThemeChild. r=ntim Since Bugzilla doesn't show Phabricator comments: r+ with the JSDoc added.
Attachment #9001369 - Flags: review?(ntim.bugs)
Comment on attachment 9001478 [details] Bug 1483664: Part 0 - Dispatch pagehide/pageshow to all system group listeners on frameloader swap. r?smaug,mconley Olli Pettay [:smaug] has approved the revision.
Attachment #9001478 - Flags: review+
Comment on attachment 9001478 [details] Bug 1483664: Part 0 - Dispatch pagehide/pageshow to all system group listeners on frameloader swap. r?smaug,mconley Mike Conley (:mconley) (:⚙️) has approved the revision.
Attachment #9001478 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/335facce978ea7f9ef1e8dcfafc082e5b99f5a47 Bug 1483664: Part 0 - Dispatch pagehide/pageshow to all system group listeners on frameloader swap. r=smaug,mconley https://hg.mozilla.org/integration/mozilla-inbound/rev/5266762e913c7b8186385023554ac73d324a724a Bug 1483664: Part 1 - Use lazy actor infrastructure for LightweightThemeChild. r=ntim
https://hg.mozilla.org/mozilla-central/rev/335facce978e https://hg.mozilla.org/mozilla-central/rev/5266762e913c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Can you please add some STRs for QA(and a test webextension if possible) or add the "qe-verify-" flag ?
Flags: needinfo?(kmaglione+bmo)
Flags: qe-verify-
Depends on: 1489780
Flags: needinfo?(kmaglione+bmo)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: