Closed Bug 1483760 Opened Last year Closed Last year

Environment Variables are not passed to cargo for MinGW Windows Builds

Categories

(Firefox Build System :: General: Unsupported Platforms, enhancement, P5)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Previously we weren't passing the variables if we were compiling for Windows
when really we only want to do it if we're compiling with MSVC/clang-cl.

The MinGW-Clang build needs this.
Comment on attachment 9001483 [details]
Bug 1483760 Additionally, pass environment variables to cargo if we are not compiling on Windows r=ted

Ted Mielczarek [:ted] [:ted.mielczarek] has approved the revision.
Attachment #9001483 - Flags: review+
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f64306b8f83
Additionally, pass environment variables to cargo if we are not compiling on Windows r=ted
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7f64306b8f83
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.