1483766 - Marionette InternalRefTestImplementation doesn't apply timeout_multiplier

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

In testing/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py, InternalRefTestImplementation sets self.self.timeout_multiplier but doesn't seem to use it for anything. It calls self.executor.protocol.marionette._send_message(... "timeout": test.timeout * 1000 ...) ... I think it should be multiplying the timeout by self.timeout_multiplier. And in practice I see that debug WPT reftests time out after 10s, when I think it should be 40s (according to testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox.py).

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Use timeout multiplier for Marionette-backed reftests.

timeout_multiplier is set in InternalRefTestImplementation's
constructor but not used.  Instead it appears to only be using the
test's timeout value.

According to the bug report by roc, reftests time out after 10
seconds, when it should be 40.

Thanks-to: Robert O'Callahan < [e-mail]>

Comment 2

[Andreas Tolfsen ❲:ato❳]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cffe422f71d5b15adab7f35d7cbe0413e558232f

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Great response, thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43de4e0d1745
Use timeout multiplier for Marionette-backed reftests. r=jgraham

Comment 5

[Andreas Tolfsen ❲:ato❳]

No, thank _you_! (-:

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12524 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 8

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/43de4e0d1745

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged