Closed Bug 1483766 Opened 2 years ago Closed 2 years ago

Marionette InternalRefTestImplementation doesn't apply timeout_multiplier

Categories

(Testing :: web-platform-tests, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: roc, Assigned: ato)

Details

Attachments

(1 file)

In testing/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py, InternalRefTestImplementation sets self.self.timeout_multiplier but doesn't seem to use it for anything. It calls self.executor.protocol.marionette._send_message(... "timeout": test.timeout * 1000 ...) ... I think it should be multiplying the timeout by self.timeout_multiplier. And in practice I see that debug WPT reftests time out after 10s, when I think it should be 40s (according to testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox.py).
timeout_multiplier is set in InternalRefTestImplementation's
constructor but not used.  Instead it appears to only be using the
test's timeout value.

According to the bug report by roc, reftests time out after 10
seconds, when it should be 40.

Thanks-to: Robert O'Callahan < roc@ocallahan.org>
Attachment #9001546 - Flags: review?(james)
Attachment #9001546 - Flags: review?(james) → review+
Assignee: nobody → ato
Status: NEW → ASSIGNED
Great response, thanks!
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43de4e0d1745
Use timeout multiplier for Marionette-backed reftests. r=jgraham
No, thank _you_! (-:
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12524 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
https://hg.mozilla.org/mozilla-central/rev/43de4e0d1745
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.