Closed Bug 1483782 Opened 2 years ago Closed 2 years ago

Replace remaining uses of webconsole.svg sprite

Categories

(DevTools :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: fvsch, Assigned: fvsch)

References

Details

Attachments

(2 files)

Depends on: bug 1479750.
Can be assigned to me.

After my proposed changes to Console icons land in bug 1479750, the webconsole.svg sprite can be removed as long as we update other tools that happen to use it:

- debugger.css (1 use)
- jit-optimisations.css (1 use)
- memory.css (1 use)
- performance.css (1 use)

I suspect most are using the "error", "warning" or "info" icons.
Depends on: 1479750
Updated the icons to *not* use a white character fill.

One instance of the alert icon is in the Performance tool, in a menu. Since the orange icon with a transparent character looked a bit strange with some backgrounds, I opted to use the text color as the icon color, which seems more consistent with how Firefox and the DevTools treat icons in menus (both system menus and Photon menus). 

Try again with those changes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f89f1b76f36aa358b7c403afb3203daf9f6e3b77
Comment on attachment 9003998 [details]
Bug 1483782 - Remove old webconsole.svg sprite; r=nchevobbe

Nicolas Chevobbe [:nchevobbe] has approved the revision.
Attachment #9003998 - Flags: review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/be371572ef39
Remove old webconsole.svg sprite; r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/be371572ef39
Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Assignee: nobody → florens
You need to log in before you can comment on or make changes to this bug.