1483782 - Replace remaining uses of webconsole.svg sprite

Status: RESOLVED FIXED

(DevTools :: General, enhancement)

Description

[Florens Verschelde :fvsch]

Depends on: bug 1479750.
Can be assigned to me.

After my proposed changes to Console icons land in bug 1479750, the webconsole.svg sprite can be removed as long as we update other tools that happen to use it:

- debugger.css (1 use)
- jit-optimisations.css (1 use)
- memory.css (1 use)
- performance.css (1 use)

I suspect most are using the "error", "warning" or "info" icons.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Here are the different usage of the sprite: https://searchfox.org/mozilla-central/search?q=webconsole.svg&case=false&regexp=false&path= .

Comment 2

[Florens Verschelde :fvsch]

Attachment: Bug 1483782 - Remove old webconsole.svg sprite; r=nchevobbe

Comment 3

[Florens Verschelde :fvsch]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ea941556cffb12baffdb13228dda89c67417acc

Comment 4

[Florens Verschelde :fvsch]

Attachment: performance-menu-alert-icon.png

Updated the icons to *not* use a white character fill.

One instance of the alert icon is in the Performance tool, in a menu. Since the orange icon with a transparent character looked a bit strange with some backgrounds, I opted to use the text color as the icon color, which seems more consistent with how Firefox and the DevTools treat icons in menus (both system menus and Photon menus). 

Try again with those changes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f89f1b76f36aa358b7c403afb3203daf9f6e3b77

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9003998 [details]
Bug 1483782 - Remove old webconsole.svg sprite; r=nchevobbe

Nicolas Chevobbe [:nchevobbe] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be371572ef39
Remove old webconsole.svg sprite; r=nchevobbe

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/be371572ef39