Closed Bug 1483910 Opened 4 years ago Closed 4 years ago

Missing favicons after bug 1480319 landed

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Version:
63 Branch
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 --- fixed

People

(Reporter: Tobias.Marty, Assigned: mossop)

References

Details

(Keywords: nightly-community, regression)

Attachments

(1 file)

Bug 1483910: Clear seenTabIcon on pagehide so subsequent loads attempt to load the root favicon. r=kmag
46 bytes, text/x-phabricator-request
kmag
: review+
Details | Review 
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180816100035

Steps to reproduce:

Installed Nightly 63.0a1 (2018-08-16) (64-bit). 


Actual results:

Lots of favicons missing most of the time. 

Examples: 
https://blog.fefe.de/
https://www.camp-firefox.de/forum/index.php
https://www.gamestar.de/xenforo/


Expected results:

Favicons are always displayed. 

Bisection points to this: 
https://bugzilla.mozilla.org/show_bug.cgi?id=1480319
Blocks: 1480319
amazon.com is broken too. All these sites are common in that they don't specify a favicon and instead rely on the browser trying the root favicon so something it broken with that logic. The network inspector suggests we aren't even attempting to load them.

Oddly if you open them in a background tab the icon loads just fine so something strange is going on with the event handling.
Status: UNCONFIRMED → NEW
Component: Untriaged → General
Ever confirmed: true
Keywords: regression
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Comment on attachment 9001708 [details]
Bug 1483910: Clear seenTabIcon on pagehide so subsequent loads attempt to load the root favicon. r=kmag

Kris Maglione [:kmag] has approved the revision.
Attachment #9001708 - Flags: review+
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3567e4333846
Clear seenTabIcon on pagehide so subsequent loads attempt to load the root favicon. r=kmag
https://hg.mozilla.org/mozilla-central/rev/3567e4333846
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.