Closed Bug 1484105 Opened 3 years ago Closed 3 years ago

Move PKG_CONFIG_LIBDIR to the top of mozconfig.linux.common

Categories

(SeaMonkey :: Build Config, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ewong, Assigned: ewong)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

PKG_CONFIG_LIBDIR was removed from m-c's mozconfigs because their 
operating system images use (iirc) Debian and apparently this env isn't
needed.  We use CentOS, so we need to add this env back.

As I understand it, should be in one of those common mozconfigs and it
has to be near the top of the caller mozconfigs.

I believe it should even be the very first entry in the main mozconfigs.

i.e.  in suite/config/mozconfigs/linux32/nightly:

TOOLTOOL_DIR=${TOOLTOOL_DIR:-$topsrcdir}

. $TOOLTOOL_DIR/build/unix/mozconfig.linux32
. $TOOLTOOL_DIR/build/mozconfig.stylo
. $TOOLTOOL_DIR/comm/suite/config/mozconfigs/mozconfig.linux.common
. $TOOLTOOL_DIR/comm/suite/config/mozconfigs/common

we either need to move the last line to the top and add PKG_CONFIG_LIBDIR
to it.
Blocks: 1484104
Also note: this should also fix the following issue:

$<3> 0:05.98$<2> checking whether the C compiler supports -Wno-gnu-zero-variadic-macro-arguments... yes$<2>
$<3> 0:06.02$<2> checking whether the C++ compiler supports -Wno-gnu-zero-variadic-macro-arguments... yes$<2>
$<3> 0:06.06$<2> checking whether the C++ compiler supports -fno-sized-deallocation... yes$<2>
$<3> 0:06.06$<2> checking for llvm-config... /builds/worker/c-cen-t-lnx64-ntly/build/clang/bin/llvm-config$<2>
$<3> 0:06.08$<2> checking for libpulse... no$<2>
$<3> 0:06.08$<2> ERROR: Package libpulse was not found in the pkg-config search path.$<2>
$<3> 0:06.08$<2> ERROR: Perhaps you should add the directory containing `libpulse.pc'$<2>
$<3> 0:06.08$<2> ERROR: to the PKG_CONFIG_PATH environment variable$<2>
$<3> 0:06.08$<2> ERROR: No package 'libpulse' found$<2>
$<3> 0:06.13$<2> *** Fix above errors and then restart with\$<2>
$<3> 0:06.13$<2>                "make -f client.mk build"$<2>
$<3> 0:06.13$<2> make: *** [configure] Error 1$<2>


(note: this was after I had manually run the mach build w/ a manually added
PKG_CONFIG_LIBDIR env to the .mozconfig file.
(In reply to Edmund Wong (:ewong) from comment #1)
> Also note: this should also fix the following issue:
> 
> $<3> 0:05.98$<2> checking whether the C compiler supports
> -Wno-gnu-zero-variadic-macro-arguments... yes$<2>
> $<3> 0:06.02$<2> checking whether the C++ compiler supports
> -Wno-gnu-zero-variadic-macro-arguments... yes$<2>
> $<3> 0:06.06$<2> checking whether the C++ compiler supports
> -fno-sized-deallocation... yes$<2>
> $<3> 0:06.06$<2> checking for llvm-config...
> /builds/worker/c-cen-t-lnx64-ntly/build/clang/bin/llvm-config$<2>
> $<3> 0:06.08$<2> checking for libpulse... no$<2>
> $<3> 0:06.08$<2> ERROR: Package libpulse was not found in the pkg-config
> search path.$<2>
> $<3> 0:06.08$<2> ERROR: Perhaps you should add the directory containing
> `libpulse.pc'$<2>
> $<3> 0:06.08$<2> ERROR: to the PKG_CONFIG_PATH environment variable$<2>
> $<3> 0:06.08$<2> ERROR: No package 'libpulse' found$<2>
> $<3> 0:06.13$<2> *** Fix above errors and then restart with\$<2>
> $<3> 0:06.13$<2>                "make -f client.mk build"$<2>
> $<3> 0:06.13$<2> make: *** [configure] Error 1$<2>
> 
> 
> (note: this was after I had manually run the mach build w/ a manually added
> PKG_CONFIG_LIBDIR env to the .mozconfig file.

Spun this off to bug 1484403 instead.
Summary: Re-add PKG_CONFIG_LIBDIR to the mozconfigs → Move PKG_CONFIG_LIBDIR to the top of mozconfig.linux.common
Apparently we do have PKG_CONFIG_LIBDIR defined.  Except  that it should be before the
mozconfig.gtk call as that's where it is needed.
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #9002171 - Flags: review?(frgrahl)
Comment on attachment 9002171 [details] [diff] [review]
[mozconfigs] move PKG_CONFIG_LIBDIR to top of mozconfig.linux.common

lgtm (frg the IanN copycat)
Attachment #9002171 - Flags: review?(frgrahl) → review+
Pushed by ewong@pw-wspx.org:
https://hg.mozilla.org/comm-central/rev/dcf8d900f223
move PKG_CONFIG_LIBDIR to the top of mozconfig.linux.common r=frg
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.