Closed
Bug 1484109
Opened 7 years ago
Closed 7 years ago
Modernize nsRelativeFilePref
Categories
(Core :: Preferences: Backend, enhancement)
Core
Preferences: Backend
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
|
3.80 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
|
941 bytes,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
|
694 bytes,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
The main purpose of this patch series is to remove the XPCOM component registration, but I've made a couple of other fixes along the way as well.
| Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ehsan
| Assignee | ||
Comment 1•7 years ago
|
||
Attachment #9001833 -
Flags: review?(n.nethercote)
| Assignee | ||
Comment 2•7 years ago
|
||
Attachment #9001834 -
Flags: review?(n.nethercote)
| Assignee | ||
Comment 3•7 years ago
|
||
Attachment #9001835 -
Flags: review?(n.nethercote)
Comment 4•7 years ago
|
||
Comment on attachment 9001833 [details] [diff] [review]
Part 1: Remove the XPCOM component registration for nsRelativeFilePref
Review of attachment 9001833 [details] [diff] [review]:
-----------------------------------------------------------------
Nice.
Attachment #9001833 -
Flags: review?(n.nethercote) → review+
Updated•7 years ago
|
Attachment #9001834 -
Flags: review?(n.nethercote) → review+
Updated•7 years ago
|
Attachment #9001835 -
Flags: review?(n.nethercote) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0da5607c48f6
Part 1: Remove the XPCOM component registration for nsRelativeFilePref; r=njn
https://hg.mozilla.org/integration/mozilla-inbound/rev/489fccb13b3e
Part 2: Make nsIRelativeFilePref non-scriptable, since there are no script consumers; r=njn
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b2b4da68f04
Part 3: Make nsRelativeFilePref final; r=njn
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0da5607c48f6
https://hg.mozilla.org/mozilla-central/rev/489fccb13b3e
https://hg.mozilla.org/mozilla-central/rev/0b2b4da68f04
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•