1484111 - Split HTMLEditor::InsertTableCell() for internal use

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac970df701c56ef4040517febc555ca73fe1c4c0

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1484111 - part 0: Add automated tests for nsITableEditor.insertTableCell.html

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1484111 - part 1: Create HTMLEditor::InsertTableCellsWithTransaction() for internal use of nsITableEditor::InsertTableCell()

nsITableEditor::InsertTableCell() is an XPCOM method but used internally.  So,
HTMLEditor should implement it with a non-virtual method and all internal users
should use it instead.

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 9010266 [details]
Bug 1484111 - part 0: Add automated tests for nsITableEditor.insertTableCell.html

Makoto Kato [:m_kato] has approved the revision.

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 9010269 [details]
Bug 1484111 - part 1: Create HTMLEditor::InsertTableCellsWithTransaction() for internal use of nsITableEditor::InsertTableCell()

Makoto Kato [:m_kato] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d10273c0ead3
part 0: Add automated tests for nsITableEditor.insertTableCell.html r=m_kato
https://hg.mozilla.org/integration/autoland/rev/7fb27b858fda
part 1: Create HTMLEditor::InsertTableCellsWithTransaction() for internal use of nsITableEditor::InsertTableCell() r=m_kato

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d10273c0ead3
https://hg.mozilla.org/mozilla-central/rev/7fb27b858fda